Skip to content

Commit

Permalink
change drift from 2 hours to 15 mins
Browse files Browse the repository at this point in the history
  • Loading branch information
@justinvforvendetta
justinvforvendetta committed Apr 4, 2018
1 parent 8ade426 commit 7294e06
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/main.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ static const int fHaveUPnP = false;
static const uint256 hashGenesisBlockOfficial("0x00000fc63692467faeb20cdb3b53200dc601d75bdfa1001463304cc790d77278");
static const uint256 hashGenesisBlockTestNet("0x65b4e101cacf3e1e4f3a9237e3a74ffd1186e595d8b78fa8ea22c21ef5bf9347");

static const int64 nMaxClockDrift = 2 * 60 * 60; // two hours
static const int64 nMaxClockDrift = 2 * 15; // fifteen minutes

This comment has been minimized.

Sign in to view

Copy link
@jahson

jahson Apr 4, 2018

2 * 60 * 60 = two hours
2 * 15 = 30 seconds
@justinvforvendetta

extern CScript COINBASE_FLAGS;

Expand Down

9 comments on commit 7294e06

@ymotton
Copy link

@ymotton ymotton commented on 7294e06 Apr 4, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinvforvendetta Assuming the previous comment was correct, and the interpretation of the const hasn't changed, shouldn't it be 15 * 60 or // thirty seconds

Also, I fail to see how this is a good solution for the issue.

@aboussof
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinvforvendetta this is not 15 minutes! that mus be 15 * 60 = 900 Seconds = 15 minutes

@mjarraya
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, pinch me

@IfaqYurmama
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmfao

@justinvforvendetta
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://wiki.peercointalk.org/index.php?title=Constants_in_peercoin_code

@ymotton
Copy link

@ymotton ymotton commented on 7294e06 Apr 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I follow @justinvforvendetta nMaxClockDrift is in seconds, no?

@aboussof
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 * 60 * 60 = 7200 Seconds / 60 seconds = 120 minutes = 2 hours
15 * 60 = 900 Seconds / 60 seconds = 15 minutes

so is correct

@justinvforvendetta
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few of us discussed this and 2 * 15 * 15 will make the window a bit shorter.

@justinvforvendetta
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

30 seconds may not work, since average block time is 30 seconds, but it has been known to vary by 15 seconds.

Please sign in to comment.