Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Clicking "Home" button from retire page displayed after Test Pilot uninstall, wrongly redirects you to experiments page #1429

Closed
SoftVision-CosminMuntean opened this issue Sep 23, 2016 · 1 comment
Closed

Clicking "Home" button from retire page displayed after Test Pilot uninstall, wrongly redirects you to experiments page #1429

SoftVision-CosminMuntean opened this issue Sep 23, 2016 · 1 comment
Assignees
@lmorchard
Projects
Project Zero - Code Quality

Comments

@SoftVision-CosminMuntean
Copy link

[Affected versions]:

  • Firefox 49 and up

[Affected Platforms]:

  • All Windows

[Prerequisites]:

  • The "testpilot.env" string pref was manually added with "dev" value on a new clean profile in "about:config" page.
  • Test Pilot add-on was previously installed on the profile.

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisite and navigate to testpilot.dev.mozaws.net/experiments/.
  2. Click on "Settings" button from top right, choose "Uninstall" option and click the "Proceed" button.
  3. Click the "Home" button and observe the browser behavior.

[Expected result]:

  • Test Pilot is successfully uninstalled and you are redirected to Test Pilot homepage.

[Actual result]:

  • Test Pilot is successfully uninstalled but you are wrongly redirected to "Experiments" page and the unistall option is still available.

[Notes]:

  • This issue is also reproducible on stage server.
  • Added a screen recording with the issue: https://goo.gl/48brhD.
@lmorchard lmorchard self-assigned this Sep 26, 2016
@johngruen johngruen added this to the TXP-0: Code Quality, Bug Fixes, Technical Debt milestone Sep 26, 2016
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 27, 2016
@lmorchard
Ensure frontend state updates when add-on uninstalled
d4053db 
- Set `window.navigator.testpilotAddon` to `false` on add-on uninstall

- Set `window.navigator.testpilotAddon` to `false` in retire dialog if
  add-on hasn't notified of uninstall within 5 seconds

Fixes mozilla#1429
@lmorchard lmorchard mentioned this issue Sep 27, 2016
Merged
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 27, 2016
@lmorchard
Ensure frontend state updates when add-on uninstalled
b811281 
- Set `window.navigator.testpilotAddon` to `false` on add-on uninstall

- Set `window.navigator.testpilotAddon` to `false` in retire dialog if
  add-on hasn't notified of uninstall within 5 seconds

Fixes mozilla#1429
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 28, 2016
@lmorchard
Ensure frontend state updates when add-on uninstalled
152883d 
- Ensure onUnload('uninstall') gets called in add-on on self-uninstall

- "Fake" uninstall timer in retire page for older add-on versions
  without the self-uninstall fixes

- Set `window.navigator.testpilotAddon` to `false` on add-on uninstall

- Set `window.navigator.testpilotAddon` to `false` in retire dialog if
  add-on hasn't notified of uninstall within 5 seconds

Fixes mozilla#1429
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 28, 2016
@lmorchard
Ensure frontend state updates when add-on uninstalled
e9b7823 
- Ensure onUnload('uninstall') gets called in add-on on self-uninstall

- "Fake" uninstall timer in retire page for older add-on versions
  without the self-uninstall fixes

- Set `window.navigator.testpilotAddon` to `false` on set-installed-flag
  page mod detach

- Set `window.navigator.testpilotAddon` to `false` in retire dialog if
  add-on hasn't notified of uninstall within 5 seconds

Fixes mozilla#1429
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 28, 2016
@lmorchard
Ensure frontend state updates when add-on uninstalled
6a06787 
- Ensure onUnload('uninstall') gets called in add-on on self-uninstall

- "Fake" uninstall timer in retire page for older add-on versions
  without the self-uninstall fixes

- Set `window.navigator.testpilotAddon` to `false` on set-installed-flag
  page mod detach

- Set `window.navigator.testpilotAddon` to `false` in retire dialog if
  add-on hasn't notified of uninstall within 5 seconds

Fixes mozilla#1429
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 28, 2016
@lmorchard
Ensure frontend state updates when add-on uninstalled
7935a78 
- Ensure onUnload('uninstall') gets called in add-on on self-uninstall

- "Fake" uninstall timer in retire page for older add-on versions
  without the self-uninstall fixes

- Set `window.navigator.testpilotAddon` to `false` on set-installed-flag
  page mod detach

- Set `window.navigator.testpilotAddon` to `false` in retire dialog if
  add-on hasn't notified of uninstall within 5 seconds

Fixes mozilla#1429
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 28, 2016
@lmorchard
Ensure frontend state updates when add-on uninstalled
349b1b5 
- Ensure onUnload('uninstall') gets called in add-on on self-uninstall

- "Fake" uninstall timer in retire page for older add-on versions
  without the self-uninstall fixes

- Set `window.navigator.testpilotAddon` to `false` on set-installed-flag
  page mod detach

- Set `window.navigator.testpilotAddon` to `false` in retire dialog if
  add-on hasn't notified of uninstall within 5 seconds

Fixes mozilla#1429
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 28, 2016
@lmorchard
Ensure frontend state updates when add-on uninstalled
29aaa93 
- Set `window.navigator.testpilotAddon` to `false` on set-installed-flag
  page mod detach

- Set `window.navigator.testpilotAddon` to `false` in retire dialog if
  add-on hasn't notified of uninstall within 5 seconds - covers older
  add-n versions without the detach fix

Fixes mozilla#1429
@SoftVision-CosminMuntean
Copy link
Author

This issue is no longer reproducible on Test Pilot dev server. I have tested this on latest Firefox (49.0.1) release and latest Nightly (52.0a1) build.

However, I have found another issue regarding to this fix. Here is the logged issue: #1484

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lmorchard lmorchard

Labels
None yet
Projects
No open projects
Project Zero - Code Quality
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lmorchard @dannycoates @johngruen @SoftVision-CosminMuntean