Bug 953694 - Requirements of Samba VFS plugin for glusterfs
Summary: Requirements of Samba VFS plugin for glusterfs
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: mainline
Hardware: Unspecified
OS: Unspecified
medium
unspecified
Target Milestone: ---
Assignee: Raghavendra Talur
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 975343
TreeView+ depends on / blocked
 
Reported: 2013-04-18 23:56 UTC by Anand Avati
Modified: 2015-09-01 23:06 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 975343 1022328 (view as bug list)
Environment:
Last Closed: 2013-08-16 06:17:26 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Anand Avati 2013-04-18 23:56:53 UTC
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2013-04-19 00:00:47 UTC
REVIEW: http://review.gluster.org/4853 (gfapi: support for chdir() and family) posted (#1) for review on master by Anand Avati (avati)

Comment 2 Anand Avati 2013-04-19 11:42:02 UTC
COMMIT: http://review.gluster.org/4853 committed in master by Vijay Bellur (vbellur) 
------
commit a1db18cf7a6cde96f2e5b920ffbbf88e72a21fd4
Author: Anand Avati <avati>
Date:   Sun Apr 14 02:58:34 2013 -0700

    gfapi: support for chdir() and family
    
    Add support for chdir, fchdir, getcwd, realpath equivalents in
    GFAPI. These are required for the Samba VFS plugin.
    
    Change-Id: I91d2db9146994403c98961c489c7640c51d5add2
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/4853
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 3 Anand Avati 2013-04-22 09:13:00 UTC
REVIEW: http://review.gluster.org/4870 (pkg-config: use -rpath instead of -R for @LIBS) posted (#1) for review on master by Anand Avati (avati)

Comment 4 Anand Avati 2013-04-23 04:49:40 UTC
REVIEW: http://review.gluster.org/4872 (gfapi: handle root (/) resolution gracefully for realpath()) posted (#1) for review on master by Anand Avati (avati)

Comment 5 Anand Avati 2013-04-23 12:34:14 UTC
COMMIT: http://review.gluster.org/4872 committed in master by Vijay Bellur (vbellur) 
------
commit fdde66da060fefcbdec664b6420658936f18b345
Author: Anand Avati <avati>
Date:   Mon Apr 22 21:34:05 2013 -0700

    gfapi: handle root (/) resolution gracefully for realpath()
    
    Resolving path of / is crucial for realpath() to work properly.
    
    Change-Id: I8a1b482beba37f01afbd20446d9e6f6125f2ec34
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/4872
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 6 Anand Avati 2013-04-23 21:18:01 UTC
REVIEW: http://review.gluster.org/4878 (syncop: set credentials of running process in @frame) posted (#1) for review on master by Anand Avati (avati)

Comment 7 Anand Avati 2013-04-23 21:34:44 UTC
REVIEW: http://review.gluster.org/4878 (syncop: set credentials of running process in @frame) posted (#2) for review on master by Anand Avati (avati)

Comment 8 Anand Avati 2013-04-23 21:35:02 UTC
REVIEW: http://review.gluster.org/4879 (syncop: implement readdirplus_r support) posted (#1) for review on master by Anand Avati (avati)

Comment 9 Anand Avati 2013-04-23 21:58:57 UTC
REVIEW: http://review.gluster.org/4879 (gfapi: implement readdirplus_r support) posted (#2) for review on master by Anand Avati (avati)

Comment 10 Anand Avati 2013-04-23 22:38:35 UTC
REVIEW: http://review.gluster.org/4879 (gfapi: implement readdirplus_r support) posted (#3) for review on master by Anand Avati (avati)

Comment 11 Anand Avati 2013-04-23 22:38:54 UTC
REVIEW: http://review.gluster.org/4878 (syncop: set credentials of running process in @frame) posted (#3) for review on master by Anand Avati (avati)

Comment 12 Anand Avati 2013-04-23 22:39:12 UTC
REVIEW: http://review.gluster.org/4881 (gfapi: POSIX locking support) posted (#1) for review on master by Anand Avati (avati)

Comment 13 Anand Avati 2013-04-24 08:05:34 UTC
COMMIT: http://review.gluster.org/4878 committed in master by Vijay Bellur (vbellur) 
------
commit 714c9776c5374496ebcecb0b139718ff5fef494b
Author: Anand Avati <avati>
Date:   Tue Apr 23 13:59:12 2013 -0700

    syncop: set credentials of running process in @frame
    
    Inherit the pid/euid/egid/groups of the running process in the
    frame. Do this only in cases where a loaded frame was not
    presented to the synctask.
    
    This behavior is required for Samba VFS.
    
    Change-Id: Ib181c90f47c6741197b9ce9f67a19e2914b647d2
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/4878
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 14 Anand Avati 2013-04-24 08:06:24 UTC
COMMIT: http://review.gluster.org/4879 committed in master by Vijay Bellur (vbellur) 
------
commit d37b2198dc8f763205f5b7e56a0e40252ccf97fe
Author: Anand Avati <avati>
Date:   Tue Apr 23 14:20:13 2013 -0700

    gfapi: implement readdirplus_r support
    
    This call is used by Samba VFS.
    
    Change-Id: Ib371502ad5a71b3b0e993f6b30e3dfb1f839c020
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/4879
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 15 Anand Avati 2013-04-24 08:06:54 UTC
COMMIT: http://review.gluster.org/4881 committed in master by Vijay Bellur (vbellur) 
------
commit 1bcb1c4d5225e197464d1c64bafd4e7ef4042e78
Author: Anand Avati <avati>
Date:   Mon Apr 15 09:52:35 2013 -0700

    gfapi: POSIX locking support
    
    Change-Id: I37d9e1fb4a715094876be6af3856c1b4cf398021
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/4881
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 16 Anand Avati 2013-05-02 05:09:29 UTC
REVIEW: http://review.gluster.org/4926 (posix-acl: fetch ACLs in readdirplus) posted (#1) for review on master by Anand Avati (avati)

Comment 17 Anand Avati 2013-05-02 05:09:53 UTC
REVIEW: http://review.gluster.org/4927 (gfapi: add new API glfs_set_xlator_option()) posted (#1) for review on master by Anand Avati (avati)

Comment 18 Anand Avati 2013-05-02 05:10:12 UTC
REVIEW: http://review.gluster.org/4928 (gfapi: optimistic resolution with ESTALE detection) posted (#1) for review on master by Anand Avati (avati)

Comment 19 Anand Avati 2013-05-02 05:10:31 UTC
REVIEW: http://review.gluster.org/4929 (md-cache: support negative xattr entries) posted (#1) for review on master by Anand Avati (avati)

Comment 20 Anand Avati 2013-05-02 05:10:50 UTC
REVIEW: http://review.gluster.org/4930 (syncop: copy inode pointer in readdirplus) posted (#1) for review on master by Anand Avati (avati)

Comment 21 Anand Avati 2013-05-02 05:11:09 UTC
REVIEW: http://review.gluster.org/4931 (gfapi: link inodes in relevant entry FOPs) posted (#1) for review on master by Anand Avati (avati)

Comment 22 Anand Avati 2013-05-02 05:11:28 UTC
REVIEW: http://review.gluster.org/4932 (pkg-config: present API version and not package version) posted (#1) for review on master by Anand Avati (avati)

Comment 23 Anand Avati 2013-05-02 05:11:47 UTC
REVIEW: http://review.gluster.org/4927 (gfapi: add new API glfs_set_xlator_option()) posted (#2) for review on master by Anand Avati (avati)

Comment 24 Anand Avati 2013-05-02 18:19:27 UTC
REVIEW: http://review.gluster.org/4931 (gfapi: link inodes in relevant entry FOPs) posted (#2) for review on master by Anand Avati (avati)

Comment 25 Anand Avati 2013-05-02 18:19:46 UTC
REVIEW: http://review.gluster.org/4930 (syncop: copy inode pointer in readdirplus) posted (#2) for review on master by Anand Avati (avati)

Comment 26 Anand Avati 2013-05-02 18:20:07 UTC
REVIEW: http://review.gluster.org/4929 (md-cache: support negative xattr entries) posted (#2) for review on master by Anand Avati (avati)

Comment 27 Anand Avati 2013-05-02 18:20:27 UTC
REVIEW: http://review.gluster.org/4928 (gfapi: optimistic resolution with ESTALE detection) posted (#2) for review on master by Anand Avati (avati)

Comment 28 Anand Avati 2013-05-02 18:20:46 UTC
REVIEW: http://review.gluster.org/4932 (pkg-config: present API version and not package version) posted (#2) for review on master by Anand Avati (avati)

Comment 29 Anand Avati 2013-05-02 18:21:05 UTC
REVIEW: http://review.gluster.org/4926 (posix-acl: fetch ACLs in readdirplus) posted (#2) for review on master by Anand Avati (avati)

Comment 30 Anand Avati 2013-05-02 18:21:24 UTC
REVIEW: http://review.gluster.org/4927 (gfapi: add new API glfs_set_xlator_option()) posted (#3) for review on master by Anand Avati (avati)

Comment 31 Anand Avati 2013-05-02 18:21:42 UTC
REVIEW: http://review.gluster.org/4941 (dht,posix: support for case discovery) posted (#1) for review on master by Anand Avati (avati)

Comment 32 Anand Avati 2013-05-03 06:16:38 UTC
COMMIT: http://review.gluster.org/4926 committed in master by Vijay Bellur (vbellur) 
------
commit aec246459b4c82fd666a3de20a55700008a5f831
Author: Anand Avati <avati>
Date:   Sat Apr 27 11:18:20 2013 -0700

    posix-acl: fetch ACLs in readdirplus
    
    Not fetching ACLs in readdirplus can potentially result in spurious
    wrong ACL decisions (which magically go away on a lookup() which
    populates the ACLs)
    
    Change-Id: Ided38b4d868fab482b477ce51b4878289ef9eed0
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/4926
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 33 Anand Avati 2013-05-03 06:21:19 UTC
COMMIT: http://review.gluster.org/4927 committed in master by Vijay Bellur (vbellur) 
------
commit 54b9cd3df357ac196af17f53282b3b1975dd4fb9
Author: Anand Avati <avati>
Date:   Sat Apr 27 11:59:36 2013 -0700

    gfapi: add new API glfs_set_xlator_option()
    
    This is the equivalent of specifying --xlator-option command line
    argument to glusterfsd.
    
    Change-Id: I1171dd518a85db4bd456fa0790f450e889a956cd
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/4927
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 34 Anand Avati 2013-05-19 03:52:44 UTC
REVIEW: http://review.gluster.org/4931 (gfapi: link inodes in relevant entry FOPs) posted (#3) for review on master by Anand Avati (avati)

Comment 35 Anand Avati 2013-05-19 03:53:05 UTC
REVIEW: http://review.gluster.org/4930 (syncop: copy inode pointer in readdirplus) posted (#3) for review on master by Anand Avati (avati)

Comment 36 Anand Avati 2013-05-19 03:53:25 UTC
REVIEW: http://review.gluster.org/4929 (md-cache: support negative xattr entries) posted (#3) for review on master by Anand Avati (avati)

Comment 37 Anand Avati 2013-05-19 03:53:44 UTC
REVIEW: http://review.gluster.org/4928 (gfapi: optimistic resolution with ESTALE detection) posted (#3) for review on master by Anand Avati (avati)

Comment 38 Anand Avati 2013-05-19 03:54:04 UTC
REVIEW: http://review.gluster.org/4932 (pkg-config: present API version and not package version) posted (#3) for review on master by Anand Avati (avati)

Comment 39 Anand Avati 2013-05-19 03:54:23 UTC
REVIEW: http://review.gluster.org/4941 (dht,posix: support for case discovery) posted (#2) for review on master by Anand Avati (avati)

Comment 40 Anand Avati 2013-05-19 03:54:43 UTC
REVIEW: http://review.gluster.org/5033 (quick-read: prune cache on write/[f]truncate) posted (#1) for review on master by Anand Avati (avati)

Comment 41 Anand Avati 2013-05-19 07:01:40 UTC
REVIEW: http://review.gluster.org/4931 (gfapi: link inodes in relevant entry FOPs) posted (#4) for review on master by Anand Avati (avati)

Comment 42 Anand Avati 2013-05-19 07:02:01 UTC
REVIEW: http://review.gluster.org/4930 (syncop: copy inode pointer in readdirplus) posted (#4) for review on master by Anand Avati (avati)

Comment 43 Anand Avati 2013-05-19 07:02:21 UTC
REVIEW: http://review.gluster.org/4929 (md-cache: support negative xattr entries) posted (#4) for review on master by Anand Avati (avati)

Comment 44 Anand Avati 2013-05-19 07:02:40 UTC
REVIEW: http://review.gluster.org/4928 (gfapi: optimistic resolution with ESTALE detection) posted (#4) for review on master by Anand Avati (avati)

Comment 45 Anand Avati 2013-05-19 07:03:00 UTC
REVIEW: http://review.gluster.org/5033 (quick-read: prune cache on write/[f]truncate) posted (#2) for review on master by Anand Avati (avati)

Comment 46 Anand Avati 2013-05-19 07:03:20 UTC
REVIEW: http://review.gluster.org/4932 (pkg-config: present API version and not package version) posted (#4) for review on master by Anand Avati (avati)

Comment 47 Anand Avati 2013-05-19 07:03:39 UTC
REVIEW: http://review.gluster.org/4941 (dht,posix: support for case discovery) posted (#3) for review on master by Anand Avati (avati)

Comment 48 Anand Avati 2013-05-19 17:14:00 UTC
REVIEW: http://review.gluster.org/4931 (gfapi: link inodes in relevant entry FOPs) posted (#5) for review on master by Anand Avati (avati)

Comment 49 Anand Avati 2013-05-19 17:14:20 UTC
REVIEW: http://review.gluster.org/4930 (syncop: copy inode pointer in readdirplus) posted (#5) for review on master by Anand Avati (avati)

Comment 50 Anand Avati 2013-05-19 17:14:40 UTC
REVIEW: http://review.gluster.org/4929 (md-cache: support negative xattr entries) posted (#5) for review on master by Anand Avati (avati)

Comment 51 Anand Avati 2013-05-19 17:14:59 UTC
REVIEW: http://review.gluster.org/4928 (gfapi: optimistic resolution with ESTALE detection) posted (#5) for review on master by Anand Avati (avati)

Comment 52 Anand Avati 2013-05-19 17:15:19 UTC
REVIEW: http://review.gluster.org/5033 (quick-read: prune cache on write/[f]truncate) posted (#3) for review on master by Anand Avati (avati)

Comment 53 Anand Avati 2013-05-19 17:15:38 UTC
REVIEW: http://review.gluster.org/4932 (pkg-config: present API version and not package version) posted (#5) for review on master by Anand Avati (avati)

Comment 54 Anand Avati 2013-05-19 17:15:58 UTC
REVIEW: http://review.gluster.org/4941 (dht,posix: support for case discovery) posted (#4) for review on master by Anand Avati (avati)

Comment 55 Anand Avati 2013-05-19 17:16:18 UTC
REVIEW: http://review.gluster.org/5035 (cluster/afr: decouple eager-lock and delayed-post-op) posted (#1) for review on master by Anand Avati (avati)

Comment 56 Anand Avati 2013-05-20 22:06:23 UTC
COMMIT: http://review.gluster.org/5033 committed in master by Anand Avati (avati) 
------
commit 27b457fad288cc896db3151bf3bc71cce72f5499
Author: Anand Avati <avati>
Date:   Sat May 18 20:35:30 2013 -0700

    quick-read: prune cache on write/[f]truncate
    
    Cache needs to be pruned on write and [f]truncate. The lack of this
    is causing Samba ping-pong test to return wierd 'data increment' values
    during startup.
    
    Change-Id: I9cd6a839bcd02de738d78638211b78f382f58e0a
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5033
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 57 Anand Avati 2013-05-20 23:22:13 UTC
REVIEW: http://review.gluster.org/4931 (gfapi: link inodes in relevant entry FOPs) posted (#8) for review on master by Anand Avati (avati)

Comment 58 Anand Avati 2013-05-20 23:22:33 UTC
REVIEW: http://review.gluster.org/4930 (syncop: copy inode pointer in readdirplus) posted (#8) for review on master by Anand Avati (avati)

Comment 59 Anand Avati 2013-05-20 23:22:54 UTC
REVIEW: http://review.gluster.org/4929 (md-cache: support negative xattr entries) posted (#8) for review on master by Anand Avati (avati)

Comment 60 Anand Avati 2013-05-20 23:23:15 UTC
REVIEW: http://review.gluster.org/4928 (gfapi: optimistic resolution with ESTALE detection) posted (#8) for review on master by Anand Avati (avati)

Comment 61 Anand Avati 2013-05-20 23:23:35 UTC
REVIEW: http://review.gluster.org/4932 (pkg-config: present API version and not package version) posted (#8) for review on master by Anand Avati (avati)

Comment 62 Anand Avati 2013-05-20 23:23:56 UTC
REVIEW: http://review.gluster.org/5045 (gfapi: provide stable st_dev in stat structure) posted (#2) for review on master by Anand Avati (avati)

Comment 63 Anand Avati 2013-05-20 23:24:16 UTC
REVIEW: http://review.gluster.org/4941 (dht,posix: support for case discovery) posted (#7) for review on master by Anand Avati (avati)

Comment 64 Anand Avati 2013-05-22 00:15:27 UTC
REVIEW: http://review.gluster.org/4931 (gfapi: link inodes in relevant entry FOPs) posted (#9) for review on master by Anand Avati (avati)

Comment 65 Anand Avati 2013-05-22 00:15:54 UTC
REVIEW: http://review.gluster.org/4930 (syncop: copy inode pointer in readdirplus) posted (#9) for review on master by Anand Avati (avati)

Comment 66 Anand Avati 2013-05-22 00:16:17 UTC
REVIEW: http://review.gluster.org/4929 (md-cache: support negative xattr entries) posted (#9) for review on master by Anand Avati (avati)

Comment 67 Anand Avati 2013-05-22 00:16:39 UTC
REVIEW: http://review.gluster.org/4928 (gfapi: optimistic resolution with ESTALE detection) posted (#9) for review on master by Anand Avati (avati)

Comment 68 Anand Avati 2013-05-22 00:17:04 UTC
REVIEW: http://review.gluster.org/4932 (pkg-config: present API version and not package version) posted (#9) for review on master by Anand Avati (avati)

Comment 69 Anand Avati 2013-05-22 00:17:29 UTC
REVIEW: http://review.gluster.org/5045 (gfapi: provide stable st_dev in stat structure) posted (#3) for review on master by Anand Avati (avati)

Comment 70 Anand Avati 2013-05-22 00:17:51 UTC
REVIEW: http://review.gluster.org/4941 (dht,posix: support for case discovery) posted (#8) for review on master by Anand Avati (avati)

Comment 71 Anand Avati 2013-05-22 00:18:13 UTC
REVIEW: http://review.gluster.org/5059 (gfapi: refresh @cwd on graph switch) posted (#1) for review on master by Anand Avati (avati)

Comment 72 Anand Avati 2013-05-22 00:32:19 UTC
REVIEW: http://review.gluster.org/4931 (gfapi: link inodes in relevant entry FOPs) posted (#10) for review on master by Anand Avati (avati)

Comment 73 Anand Avati 2013-05-22 00:32:53 UTC
REVIEW: http://review.gluster.org/4930 (syncop: copy inode pointer in readdirplus) posted (#10) for review on master by Anand Avati (avati)

Comment 74 Anand Avati 2013-05-22 00:33:14 UTC
REVIEW: http://review.gluster.org/4929 (md-cache: support negative xattr entries) posted (#10) for review on master by Anand Avati (avati)

Comment 75 Anand Avati 2013-05-22 00:33:38 UTC
REVIEW: http://review.gluster.org/4928 (gfapi: optimistic resolution with ESTALE detection) posted (#10) for review on master by Anand Avati (avati)

Comment 76 Anand Avati 2013-05-22 00:33:59 UTC
REVIEW: http://review.gluster.org/4932 (pkg-config: present API version and not package version) posted (#10) for review on master by Anand Avati (avati)

Comment 77 Anand Avati 2013-05-22 00:34:37 UTC
REVIEW: http://review.gluster.org/5045 (gfapi: provide stable st_dev in stat structure) posted (#4) for review on master by Anand Avati (avati)

Comment 78 Anand Avati 2013-05-22 00:34:57 UTC
REVIEW: http://review.gluster.org/5059 (gfapi: refresh @cwd on graph switch) posted (#2) for review on master by Anand Avati (avati)

Comment 79 Anand Avati 2013-05-22 00:35:20 UTC
REVIEW: http://review.gluster.org/4941 (dht,posix: support for case discovery) posted (#9) for review on master by Anand Avati (avati)

Comment 80 Anand Avati 2013-05-22 00:36:45 UTC
REVIEW: http://review.gluster.org/4931 (gfapi: link inodes in relevant entry FOPs) posted (#11) for review on master by Anand Avati (avati)

Comment 81 Anand Avati 2013-05-22 00:37:06 UTC
REVIEW: http://review.gluster.org/4930 (syncop: copy inode pointer in readdirplus) posted (#11) for review on master by Anand Avati (avati)

Comment 82 Anand Avati 2013-05-22 00:37:27 UTC
REVIEW: http://review.gluster.org/4929 (md-cache: support negative xattr entries) posted (#11) for review on master by Anand Avati (avati)

Comment 83 Anand Avati 2013-05-22 00:37:47 UTC
REVIEW: http://review.gluster.org/4928 (gfapi: optimistic resolution with ESTALE detection) posted (#11) for review on master by Anand Avati (avati)

Comment 84 Anand Avati 2013-05-22 00:38:08 UTC
REVIEW: http://review.gluster.org/4932 (pkg-config: present API version and not package version) posted (#11) for review on master by Anand Avati (avati)

Comment 85 Anand Avati 2013-05-22 00:38:28 UTC
REVIEW: http://review.gluster.org/5045 (gfapi: provide stable st_dev in stat structure) posted (#5) for review on master by Anand Avati (avati)

Comment 86 Anand Avati 2013-05-22 00:38:49 UTC
REVIEW: http://review.gluster.org/5059 (gfapi: refresh @cwd on graph switch) posted (#3) for review on master by Anand Avati (avati)

Comment 87 Anand Avati 2013-05-22 00:39:10 UTC
REVIEW: http://review.gluster.org/4941 (dht,posix: support for case discovery) posted (#10) for review on master by Anand Avati (avati)

Comment 88 Anand Avati 2013-05-22 04:04:29 UTC
REVIEW: http://review.gluster.org/4931 (gfapi: link inodes in relevant entry FOPs) posted (#12) for review on master by Anand Avati (avati)

Comment 89 Anand Avati 2013-05-22 04:04:51 UTC
REVIEW: http://review.gluster.org/4930 (syncop: copy inode pointer in readdirplus) posted (#12) for review on master by Anand Avati (avati)

Comment 90 Anand Avati 2013-05-22 04:05:12 UTC
REVIEW: http://review.gluster.org/4929 (md-cache: support negative xattr entries) posted (#12) for review on master by Anand Avati (avati)

Comment 91 Anand Avati 2013-05-22 04:05:34 UTC
REVIEW: http://review.gluster.org/4928 (gfapi: optimistic resolution with ESTALE detection) posted (#12) for review on master by Anand Avati (avati)

Comment 92 Anand Avati 2013-05-22 04:05:55 UTC
REVIEW: http://review.gluster.org/4932 (pkg-config: present API version and not package version) posted (#12) for review on master by Anand Avati (avati)

Comment 93 Anand Avati 2013-05-22 04:06:16 UTC
REVIEW: http://review.gluster.org/5045 (gfapi: provide stable st_dev in stat structure) posted (#6) for review on master by Anand Avati (avati)

Comment 94 Anand Avati 2013-05-22 04:06:37 UTC
REVIEW: http://review.gluster.org/5059 (gfapi: refresh @cwd on graph switch) posted (#4) for review on master by Anand Avati (avati)

Comment 95 Anand Avati 2013-05-22 04:06:58 UTC
REVIEW: http://review.gluster.org/4941 (dht,posix: support for case discovery) posted (#11) for review on master by Anand Avati (avati)

Comment 96 Anand Avati 2013-05-23 10:21:45 UTC
REVIEW: http://review.gluster.org/4931 (gfapi: link inodes in relevant entry FOPs) posted (#13) for review on master by Anand Avati (avati)

Comment 97 Anand Avati 2013-05-23 10:22:14 UTC
REVIEW: http://review.gluster.org/4930 (syncop: copy inode pointer in readdirplus) posted (#13) for review on master by Anand Avati (avati)

Comment 98 Anand Avati 2013-05-23 10:22:40 UTC
REVIEW: http://review.gluster.org/4929 (md-cache: support negative xattr entries) posted (#13) for review on master by Anand Avati (avati)

Comment 99 Anand Avati 2013-05-23 10:23:05 UTC
REVIEW: http://review.gluster.org/4928 (gfapi: optimistic resolution with ESTALE detection) posted (#13) for review on master by Anand Avati (avati)

Comment 100 Anand Avati 2013-05-23 10:23:37 UTC
REVIEW: http://review.gluster.org/4932 (pkg-config: present API version and not package version) posted (#13) for review on master by Anand Avati (avati)

Comment 101 Anand Avati 2013-05-23 10:24:02 UTC
REVIEW: http://review.gluster.org/5045 (gfapi: provide stable st_dev in stat structure) posted (#7) for review on master by Anand Avati (avati)

Comment 102 Anand Avati 2013-05-23 10:24:24 UTC
REVIEW: http://review.gluster.org/5059 (gfapi: handle graph switch (cwd, fds, locks)) posted (#5) for review on master by Anand Avati (avati)

Comment 103 Anand Avati 2013-05-23 10:24:44 UTC
REVIEW: http://review.gluster.org/4941 (dht,posix: support for case discovery) posted (#12) for review on master by Anand Avati (avati)

Comment 104 Anand Avati 2013-05-23 20:10:04 UTC
REVIEW: http://review.gluster.org/4931 (gfapi: link inodes in relevant entry FOPs) posted (#14) for review on master by Anand Avati (avati)

Comment 105 Anand Avati 2013-05-23 20:10:26 UTC
REVIEW: http://review.gluster.org/4930 (syncop: copy inode pointer in readdirplus) posted (#14) for review on master by Anand Avati (avati)

Comment 106 Anand Avati 2013-05-23 20:10:48 UTC
REVIEW: http://review.gluster.org/4929 (md-cache: support negative xattr entries) posted (#14) for review on master by Anand Avati (avati)

Comment 107 Anand Avati 2013-05-23 20:11:12 UTC
REVIEW: http://review.gluster.org/4928 (gfapi: optimistic resolution with ESTALE detection) posted (#14) for review on master by Anand Avati (avati)

Comment 108 Anand Avati 2013-05-23 20:11:34 UTC
REVIEW: http://review.gluster.org/4932 (pkg-config: present API version and not package version) posted (#14) for review on master by Anand Avati (avati)

Comment 109 Anand Avati 2013-05-23 20:11:57 UTC
REVIEW: http://review.gluster.org/5045 (gfapi: provide stable st_dev in stat structure) posted (#8) for review on master by Anand Avati (avati)

Comment 110 Anand Avati 2013-05-23 20:12:21 UTC
REVIEW: http://review.gluster.org/5059 (gfapi: handle graph switch (cwd, fds, locks)) posted (#6) for review on master by Anand Avati (avati)

Comment 111 Anand Avati 2013-05-23 20:12:45 UTC
REVIEW: http://review.gluster.org/4941 (dht,posix: support for case discovery) posted (#13) for review on master by Anand Avati (avati)

Comment 112 Anand Avati 2013-05-24 06:28:55 UTC
REVIEW: http://review.gluster.org/4931 (gfapi: link inodes in relevant entry FOPs) posted (#15) for review on master by Anand Avati (avati)

Comment 113 Anand Avati 2013-05-24 06:29:17 UTC
REVIEW: http://review.gluster.org/4930 (syncop: copy inode pointer in readdirplus) posted (#15) for review on master by Anand Avati (avati)

Comment 114 Anand Avati 2013-05-24 06:29:39 UTC
REVIEW: http://review.gluster.org/4929 (md-cache: support negative xattr entries) posted (#15) for review on master by Anand Avati (avati)

Comment 115 Anand Avati 2013-05-24 06:30:18 UTC
REVIEW: http://review.gluster.org/4932 (pkg-config: present API version and not package version) posted (#15) for review on master by Anand Avati (avati)

Comment 116 Anand Avati 2013-05-24 06:30:39 UTC
REVIEW: http://review.gluster.org/5045 (gfapi: provide stable st_dev in stat structure) posted (#9) for review on master by Anand Avati (avati)

Comment 117 Anand Avati 2013-05-24 06:31:03 UTC
REVIEW: http://review.gluster.org/5059 (gfapi: handle graph switch (cwd, fds, locks)) posted (#7) for review on master by Anand Avati (avati)

Comment 118 Anand Avati 2013-05-24 06:31:25 UTC
REVIEW: http://review.gluster.org/4941 (dht,posix: support for case discovery) posted (#14) for review on master by Anand Avati (avati)

Comment 119 Anand Avati 2013-05-24 06:31:47 UTC
REVIEW: http://review.gluster.org/5085 (gfapi: ignore NULL and -1 parameters in glfs_set_logging()) posted (#1) for review on master by Anand Avati (avati)

Comment 120 Anand Avati 2013-05-25 06:45:02 UTC
REVIEW: http://review.gluster.org/4931 (gfapi: link inodes in relevant entry FOPs) posted (#16) for review on master by Anand Avati (avati)

Comment 121 Anand Avati 2013-05-25 06:45:25 UTC
REVIEW: http://review.gluster.org/4930 (syncop: copy inode pointer in readdirplus) posted (#16) for review on master by Anand Avati (avati)

Comment 122 Anand Avati 2013-05-25 06:45:45 UTC
REVIEW: http://review.gluster.org/4929 (md-cache: support negative xattr entries) posted (#16) for review on master by Anand Avati (avati)

Comment 123 Anand Avati 2013-05-25 06:46:06 UTC
REVIEW: http://review.gluster.org/4928 (gfapi: optimistic resolution with ESTALE detection) posted (#16) for review on master by Anand Avati (avati)

Comment 124 Anand Avati 2013-05-25 06:46:27 UTC
REVIEW: http://review.gluster.org/5085 (gfapi: ignore NULL and -1 parameters in glfs_set_logging()) posted (#2) for review on master by Anand Avati (avati)

Comment 125 Anand Avati 2013-05-25 06:46:48 UTC
REVIEW: http://review.gluster.org/4932 (pkg-config: present API version and not package version) posted (#16) for review on master by Anand Avati (avati)

Comment 126 Anand Avati 2013-05-25 06:47:09 UTC
REVIEW: http://review.gluster.org/5045 (gfapi: provide stable st_dev in stat structure) posted (#10) for review on master by Anand Avati (avati)

Comment 127 Anand Avati 2013-05-25 06:47:30 UTC
REVIEW: http://review.gluster.org/5059 (gfapi: handle graph switch (cwd, fds, locks)) posted (#8) for review on master by Anand Avati (avati)

Comment 128 Anand Avati 2013-05-25 06:47:51 UTC
REVIEW: http://review.gluster.org/4941 (dht,posix: support for case discovery) posted (#15) for review on master by Anand Avati (avati)

Comment 129 Anand Avati 2013-05-25 09:05:50 UTC
REVIEW: http://review.gluster.org/4931 (gfapi: link inodes in relevant entry FOPs) posted (#17) for review on master by Anand Avati (avati)

Comment 130 Anand Avati 2013-05-25 09:06:12 UTC
REVIEW: http://review.gluster.org/4930 (syncop: copy inode pointer in readdirplus) posted (#17) for review on master by Anand Avati (avati)

Comment 131 Anand Avati 2013-05-25 09:06:33 UTC
REVIEW: http://review.gluster.org/4929 (md-cache: support negative xattr entries) posted (#17) for review on master by Anand Avati (avati)

Comment 132 Anand Avati 2013-05-25 09:06:54 UTC
REVIEW: http://review.gluster.org/4928 (gfapi: optimistic resolution with ESTALE detection) posted (#17) for review on master by Anand Avati (avati)

Comment 133 Anand Avati 2013-05-25 09:07:16 UTC
REVIEW: http://review.gluster.org/5085 (gfapi: ignore NULL and -1 parameters in glfs_set_logging()) posted (#3) for review on master by Anand Avati (avati)

Comment 134 Anand Avati 2013-05-25 09:07:37 UTC
REVIEW: http://review.gluster.org/4932 (pkg-config: present API version and not package version) posted (#17) for review on master by Anand Avati (avati)

Comment 135 Anand Avati 2013-05-25 09:07:59 UTC
REVIEW: http://review.gluster.org/5045 (gfapi: provide stable st_dev in stat structure) posted (#11) for review on master by Anand Avati (avati)

Comment 136 Anand Avati 2013-05-25 09:08:20 UTC
REVIEW: http://review.gluster.org/5059 (gfapi: handle graph switch (cwd, fds, locks)) posted (#9) for review on master by Anand Avati (avati)

Comment 137 Anand Avati 2013-05-25 09:08:40 UTC
REVIEW: http://review.gluster.org/4941 (dht,posix: support for case discovery) posted (#16) for review on master by Anand Avati (avati)

Comment 138 Anand Avati 2013-05-25 09:09:01 UTC
REVIEW: http://review.gluster.org/4931 (gfapi: link inodes in relevant entry FOPs) posted (#18) for review on master by Anand Avati (avati)

Comment 139 Anand Avati 2013-05-25 09:09:22 UTC
REVIEW: http://review.gluster.org/4930 (syncop: copy inode pointer in readdirplus) posted (#18) for review on master by Anand Avati (avati)

Comment 140 Anand Avati 2013-05-25 09:09:43 UTC
REVIEW: http://review.gluster.org/4929 (md-cache: support negative xattr entries) posted (#18) for review on master by Anand Avati (avati)

Comment 141 Anand Avati 2013-05-25 09:10:09 UTC
REVIEW: http://review.gluster.org/4928 (gfapi: optimistic resolution with ESTALE detection) posted (#18) for review on master by Anand Avati (avati)

Comment 142 Anand Avati 2013-05-25 09:10:30 UTC
REVIEW: http://review.gluster.org/5085 (gfapi: ignore NULL and -1 parameters in glfs_set_logging()) posted (#4) for review on master by Anand Avati (avati)

Comment 143 Anand Avati 2013-05-25 09:10:51 UTC
REVIEW: http://review.gluster.org/4932 (pkg-config: present API version and not package version) posted (#18) for review on master by Anand Avati (avati)

Comment 144 Anand Avati 2013-05-25 09:11:12 UTC
REVIEW: http://review.gluster.org/5045 (gfapi: provide stable st_dev in stat structure) posted (#12) for review on master by Anand Avati (avati)

Comment 145 Anand Avati 2013-05-25 09:11:33 UTC
REVIEW: http://review.gluster.org/5059 (gfapi: handle graph switch (cwd, fds, locks)) posted (#10) for review on master by Anand Avati (avati)

Comment 146 Anand Avati 2013-05-25 09:11:54 UTC
REVIEW: http://review.gluster.org/4941 (dht,posix: support for case discovery) posted (#17) for review on master by Anand Avati (avati)

Comment 147 Anand Avati 2013-05-25 18:35:38 UTC
COMMIT: http://review.gluster.org/4928 committed in master by Vijay Bellur (vbellur) 
------
commit e9ac9d4d5c1c3e9f3f0b5c80a881d67a675eccef
Author: Anand Avati <avati>
Date:   Sat Apr 27 21:40:19 2013 -0700

    gfapi: optimistic resolution with ESTALE detection
    
    Enhance the path resolver to be optimistic. Instead of performing
    a wasteful ->lookup() fop for every component in every API call,
    build in speculation logic to consider the previous resolution
    result temporarily, and if it results in ESTALE either later in
    the path resolution or in the FOP, then retry resolution with
    ->lookup() at every level and retry the FOP.
    
    This is the same optimistic resolution/retry logic Linux kernel
    resolver is proposing to use.
    
    Change-Id: Iecbc25248754caf0915cd7205910563ff88ce5e7
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/4928
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 148 Anand Avati 2013-05-25 18:36:23 UTC
COMMIT: http://review.gluster.org/4929 committed in master by Vijay Bellur (vbellur) 
------
commit 5b2117650a8c8e83ce9ea6f325f8e63053a1af2c
Author: Anand Avati <avati>
Date:   Sat Apr 27 11:40:02 2013 -0700

    md-cache: support negative xattr entries
    
    Add support for negative xattr caching. For this, we need
    to fetch xattrs in every opportunity (including readdirplus)
    in order to treat missing key in cached dict as negative entry.
    
    This is crucial to detect missing ACL xattrs in Samba workload.
    
    Change-Id: I918a2ef4ab804724256f7546b15e808332ed518d
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/4929
    Reviewed-by: Vijay Bellur <vbellur>
    Tested-by: Gluster Build System <jenkins.com>

Comment 149 Anand Avati 2013-05-25 18:36:53 UTC
COMMIT: http://review.gluster.org/4930 committed in master by Vijay Bellur (vbellur) 
------
commit 79387af286421c0668f21a2c34adc9f18f6da464
Author: Anand Avati <avati>
Date:   Sun Apr 28 02:01:01 2013 -0700

    syncop: copy inode pointer in readdirplus
    
    Change-Id: I9ab2b8ac2da9fe13f56b8b08f715a0b603ece0cb
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/4930
    Reviewed-by: Vijay Bellur <vbellur>
    Tested-by: Gluster Build System <jenkins.com>

Comment 150 Anand Avati 2013-05-25 18:37:23 UTC
COMMIT: http://review.gluster.org/4931 committed in master by Vijay Bellur (vbellur) 
------
commit 9b645be90f76e71f3d1587db66c0c1f9599e5b2d
Author: Anand Avati <avati>
Date:   Sun Apr 28 12:22:54 2013 -0700

    gfapi: link inodes in relevant entry FOPs
    
    Do not let inode linking to happen only in lookup(). While
    that works, it is inefficient.
    
    Change-Id: I51bbfb6255ec4324ab17ff00566375f49d120c06
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/4931
    Reviewed-by: Vijay Bellur <vbellur>
    Tested-by: Gluster Build System <jenkins.com>

Comment 151 Anand Avati 2013-05-25 18:38:04 UTC
COMMIT: http://review.gluster.org/4941 committed in master by Vijay Bellur (vbellur) 
------
commit 05aaec645a6262d431486eb5ac7cd702646cfcfb
Author: Anand Avati <avati>
Date:   Thu May 2 08:00:22 2013 -0700

    dht,posix: support for case discovery
    
    This is support for discovering a filename in a given directory
    which has a case insensitive match of a given name. It is implemented
    as a virtual extended attribute on the directory where the required
    filename is specified in the key.
    
    E.g:
    
      sh# getfattr -e "text" -n user.glusterfs.get_real_filename:FiLe-B /mnt/samba/patchy
      getfattr: Removing leading '/' from absolute path names
      # file: mnt/samba/patchy
      user.glusterfs.get_real_filename:FiLe-B="file-b"
    
    In reality, there can be multiple "answers" as the backend filesystem is
    case sensitive and there can be multiple files which can strcasecamp()
    successfully. In this case we pick the first matched file from the first
    responding server.
    
    If a matching file does not exist, we return ENOENT (and NOT ENODATA).
    This way the caller can differentiate between "unsupported" glusterfs
    API and file not existing.
    
    This API is used by Samba VFS to perform efficient discovery of the real
    filename without doing a full scan at the Samba level.
    
    Change-Id: I53054c4067cba69e585fd0bbce004495bc6e39e8
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/4941
    Reviewed-by: Vijay Bellur <vbellur>
    Tested-by: Gluster Build System <jenkins.com>

Comment 152 Anand Avati 2013-05-25 18:39:52 UTC
COMMIT: http://review.gluster.org/5045 committed in master by Vijay Bellur (vbellur) 
------
commit ed11e88b77fe45acd1181728435bb644607a2b22
Author: Anand Avati <avati>
Date:   Sun May 19 23:31:38 2013 -0700

    gfapi: provide stable st_dev in stat structure
    
    Samba depends on st_dev being unique and stable for different
    filesystems (it uses st_dev+st_ino as key to store metadata of
    a file).
    
    Change-Id: Ia022fabadfb5ef3fc9724c1b1ca86f1a20f98af9
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5045
    Reviewed-by: Vijay Bellur <vbellur>
    Tested-by: Gluster Build System <jenkins.com>

Comment 153 Anand Avati 2013-05-25 18:40:21 UTC
COMMIT: http://review.gluster.org/4932 committed in master by Vijay Bellur (vbellur) 
------
commit c04a0ca7cf3a9775e21d51f9bdaa113b0f19f051
Author: Anand Avati <avati>
Date:   Wed Apr 24 00:51:12 2013 -0700

    pkg-config: present API version and not package version
    
    This way PKG_MODULE() autoconf test checks for required API
    rather than release version (e.g required API could be in all
    all of 3.4.5, 3.5.1, 3.6.4 etc.)
    
    With the first "release" of gfapi, the current version (4) will
    be frozen.
    
    Version 3 is sufficient for QEMU's requirement. Version 4 is
    necessary for Samba VFS
    
    Change-Id: Iada3a4c88b9c67413dcd57004fd8a62926a21b42
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/4932
    Reviewed-by: Vijay Bellur <vbellur>
    Tested-by: Gluster Build System <jenkins.com>

Comment 154 Anand Avati 2013-05-25 18:40:52 UTC
COMMIT: http://review.gluster.org/5085 committed in master by Vijay Bellur (vbellur) 
------
commit 2a2244972082c026061a08c76d03ec2f19b0d438
Author: Anand Avati <avati>
Date:   Thu May 23 23:14:30 2013 -0700

    gfapi: ignore NULL and -1 parameters in glfs_set_logging()
    
    Permit changing either logfile or level by specifying the other
    as -1 or NULL respectively.
    
    Change-Id: I7df05db7b613c57e0106a5cce846ae26d2a160d4
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5085
    Reviewed-by: Vijay Bellur <vbellur>
    Tested-by: Gluster Build System <jenkins.com>

Comment 155 Anand Avati 2013-05-28 07:09:29 UTC
COMMIT: http://review.gluster.org/5059 committed in master by Anand Avati (avati) 
------
commit 1a5e8638a177ac90177ae1b749b89c984930c875
Author: Anand Avati <avati>
Date:   Tue May 21 16:27:09 2013 -0700

    gfapi: handle graph switch (cwd, fds, locks)
    
    - Migrate open fds to new graph
    - Migrate locks held in open fd to new fd
    - Refresh CWD, so resolution of relative paths happens on refreshed
      inode (on new graph).
    
    Change-Id: I4b18083b9b290107ebda1f917fc85b635ab72fb4
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5059
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra G <raghavendra>

Comment 156 Anand Avati 2013-05-29 10:33:04 UTC
REVIEW: http://review.gluster.org/5104 (socket: convert socket functions to file scope (static)) posted (#1) for review on master by Anand Avati (avati)

Comment 157 Anand Avati 2013-05-29 10:33:28 UTC
REVIEW: http://review.gluster.org/5105 (api/Makefile: link api.so against libgfapi (and dependencies)) posted (#1) for review on master by Anand Avati (avati)

Comment 158 Anand Avati 2013-05-29 10:41:53 UTC
REVIEW: http://review.gluster.org/5105 (api/Makefile: link api.so against libgfapi (and dependencies)) posted (#2) for review on master by Anand Avati (avati)

Comment 159 Anand Avati 2013-05-29 10:42:16 UTC
REVIEW: http://review.gluster.org/5104 (socket: convert socket functions to file scope (static)) posted (#2) for review on master by Anand Avati (avati)

Comment 160 Anand Avati 2013-05-29 10:49:49 UTC
REVIEW: http://review.gluster.org/5105 (api/Makefile: link api.so against libgfapi (and dependencies)) posted (#3) for review on master by Anand Avati (avati)

Comment 161 Anand Avati 2013-05-29 10:50:11 UTC
REVIEW: http://review.gluster.org/5104 (socket: convert socket functions to file scope (static)) posted (#3) for review on master by Anand Avati (avati)

Comment 162 Anand Avati 2013-05-29 12:27:37 UTC
COMMIT: http://review.gluster.org/5104 committed in master by Vijay Bellur (vbellur) 
------
commit ac8deb16b5f0aa131373f945cec205af90eaad4d
Author: Anand Avati <avati>
Date:   Wed May 29 03:12:19 2013 -0700

    socket: convert socket functions to file scope (static)
    
    The function names used in socket.c conflict with Samba's
    socket functions (samba.git/source4/lib/socket/socket.h). Convert
    our functions to file scope as they are anyways not called across
    files.
    
    Change-Id: If98ae557d3e2868f257c021b283ede6a5e92de02
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5104
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 163 Anand Avati 2013-05-29 12:28:09 UTC
COMMIT: http://review.gluster.org/5105 committed in master by Vijay Bellur (vbellur) 
------
commit deaf7574a6cb519cf678196476697db9fe69edd0
Author: Anand Avati <avati>
Date:   Wed May 29 03:15:19 2013 -0700

    api/Makefile: link api.so against libgfapi (and dependencies)
    
    Samba opens vfs_gluster.so with dlopen(..,RTLD_LOCAL). This makes
    the symobls in the shared module and the library it exclusively
    links against (specifically gfapi) not resolvable from the .so
    files which are opened in turn within (like xlator .so files)
    unless explicitly linked against the dependent libraries.
    
    This is not otherwise required in case of glusterfsd as the main
    executable symbols are always available for resolution from
    dlopen()'ed shared objects, making Samba's vfs_glusterfs
    requirement unique, but luckily not incompatible.
    
    Change-Id: I894c521daade7d46ec5bf07793f2eea02ebc9700
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5105
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 164 Anand Avati 2013-05-29 19:46:08 UTC
REVIEW: http://review.gluster.org/5109 (gfapi: add new API glfs_dup() to copy a file descriptor) posted (#1) for review on master by Anand Avati (avati)

Comment 165 Anand Avati 2013-05-29 19:48:43 UTC
REVIEW: http://review.gluster.org/5109 (gfapi: add new API glfs_dup() to copy a file descriptor) posted (#2) for review on master by Anand Avati (avati)

Comment 166 Anand Avati 2013-05-29 23:15:31 UTC
REVIEW: http://review.gluster.org/5111 (core: increase the auxillary group limit to 65536) posted (#1) for review on master by Anand Avati (avati)

Comment 167 Anand Avati 2013-05-29 23:19:40 UTC
REVIEW: http://review.gluster.org/5111 (core: increase the auxillary group limit to 65536) posted (#2) for review on master by Anand Avati (avati)

Comment 168 Anand Avati 2013-05-29 23:27:33 UTC
REVIEW: http://review.gluster.org/5111 (core: increase the auxillary group limit to 65536) posted (#3) for review on master by Anand Avati (avati)

Comment 169 Anand Avati 2013-05-30 04:41:27 UTC
COMMIT: http://review.gluster.org/5109 committed in master by Vijay Bellur (vbellur) 
------
commit 7646169f20d2e2f23c6033347f019ee60521a524
Author: Anand Avati <avati>
Date:   Thu May 2 20:01:18 2013 -0700

    gfapi: add new API glfs_dup() to copy a file descriptor
    
    Duplicate a glfs_fd file descriptor. Inherit the internal
    fd_t with a reference.
    
    Change-Id: Ib30e9a46b608b9f78202957f4dab6ba6265a9ec0
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5109
    Reviewed-by: Raghavendra Talur <rtalur>
    Tested-by: Gluster Build System <jenkins.com>

Comment 170 Anand Avati 2013-05-30 18:23:08 UTC
REVIEW: http://review.gluster.org/5118 (api: Fix api.so and libgfapi.so build time dependency) posted (#1) for review on master by Anand Avati (avati)

Comment 171 Anand Avati 2013-05-31 06:45:01 UTC
COMMIT: http://review.gluster.org/5118 committed in master by Vijay Bellur (vbellur) 
------
commit 83e4a149bd69d13fdd6fd4c80e603e04d15ff8e3
Author: Anand Avati <avati>
Date:   Fri May 3 05:44:17 2013 -0700

    api: Fix api.so and libgfapi.so build time dependency
    
    Not all versions of autoconf handle dependencies expressed
    as "A: B". Use the xxx_DEPENDENCIES variable to make it
    version independent
    
    Change-Id: Ia0b13399d0bf10995d9845e04cd9eb3ef6518dbe
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5118
    Reviewed-by: Raghavendra Talur <rtalur>
    Tested-by: Gluster Build System <jenkins.com>

Comment 172 Anand Avati 2013-06-05 22:29:28 UTC
REVIEW: http://review.gluster.org/5151 (gfapi: support for chdir() and family) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 173 Anand Avati 2013-06-05 22:29:54 UTC
REVIEW: http://review.gluster.org/5152 (gfapi: handle root (/) resolution gracefully for realpath()) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 174 Anand Avati 2013-06-05 22:30:16 UTC
REVIEW: http://review.gluster.org/5153 (syncop: set credentials of running process in @frame) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 175 Anand Avati 2013-06-05 22:30:38 UTC
REVIEW: http://review.gluster.org/5154 (gfapi: implement readdirplus_r support) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 176 Anand Avati 2013-06-05 22:31:00 UTC
REVIEW: http://review.gluster.org/5155 (gfapi: POSIX locking support) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 177 Anand Avati 2013-06-05 22:31:22 UTC
REVIEW: http://review.gluster.org/5156 (posix-acl: fetch ACLs in readdirplus) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 178 Anand Avati 2013-06-05 22:31:44 UTC
REVIEW: http://review.gluster.org/5157 (gfapi: add new API glfs_set_xlator_option()) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 179 Anand Avati 2013-06-05 22:32:06 UTC
REVIEW: http://review.gluster.org/5158 (quick-read: prune cache on write/[f]truncate) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 180 Anand Avati 2013-06-05 22:32:28 UTC
REVIEW: http://review.gluster.org/5159 (gfapi: optimistic resolution with ESTALE detection) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 181 Anand Avati 2013-06-05 22:32:50 UTC
REVIEW: http://review.gluster.org/5160 (md-cache: support negative xattr entries) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 182 Anand Avati 2013-06-05 22:33:12 UTC
REVIEW: http://review.gluster.org/5161 (syncop: copy inode pointer in readdirplus) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 183 Anand Avati 2013-06-05 22:33:34 UTC
REVIEW: http://review.gluster.org/5162 (gfapi: link inodes in relevant entry FOPs) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 184 Anand Avati 2013-06-05 22:33:56 UTC
REVIEW: http://review.gluster.org/5163 (dht,posix: support for case discovery) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 185 Anand Avati 2013-06-05 22:34:18 UTC
REVIEW: http://review.gluster.org/5164 (gfapi: provide stable st_dev in stat structure) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 186 Anand Avati 2013-06-05 22:34:40 UTC
REVIEW: http://review.gluster.org/5165 (pkg-config: present API version and not package version) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 187 Anand Avati 2013-06-05 22:35:02 UTC
REVIEW: http://review.gluster.org/5166 (gfapi: ignore NULL and -1 parameters in glfs_set_logging()) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 188 Anand Avati 2013-06-05 22:35:29 UTC
REVIEW: http://review.gluster.org/5167 (gfapi: handle graph switch (cwd, fds, locks)) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 189 Anand Avati 2013-06-05 22:35:51 UTC
REVIEW: http://review.gluster.org/5168 (socket: convert socket functions to file scope (static)) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 190 Anand Avati 2013-06-05 22:36:13 UTC
REVIEW: http://review.gluster.org/5169 (api/Makefile: link api.so against libgfapi (and dependencies)) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 191 Anand Avati 2013-06-05 22:36:35 UTC
REVIEW: http://review.gluster.org/5170 (gfapi: add new API glfs_dup() to copy a file descriptor) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 192 Anand Avati 2013-06-05 22:36:57 UTC
REVIEW: http://review.gluster.org/5171 (api: Fix api.so and libgfapi.so build time dependency) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 193 Anand Avati 2013-06-05 22:37:20 UTC
REVIEW: http://review.gluster.org/5172 (core: increase the auxillary group limit to 65536) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 194 Anand Avati 2013-06-08 21:39:08 UTC
COMMIT: http://review.gluster.org/5151 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit f44ada6cd9bcc5ab98ca66bedde4fe23dd1c3f05
Author: Anand Avati <avati>
Date:   Sun Apr 14 02:58:34 2013 -0700

    gfapi: support for chdir() and family
    
    Add support for chdir, fchdir, getcwd, realpath equivalents in
    GFAPI. These are required for the Samba VFS plugin.
    
    Change-Id: I91d2db9146994403c98961c489c7640c51d5add2
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5151
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 195 Anand Avati 2013-06-08 21:39:42 UTC
COMMIT: http://review.gluster.org/5152 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit 1e2211d47c9fae3eb8dcb32aa7f170ba9d104134
Author: Anand Avati <avati>
Date:   Mon Apr 22 21:34:05 2013 -0700

    gfapi: handle root (/) resolution gracefully for realpath()
    
    Resolving path of / is crucial for realpath() to work properly.
    
    Change-Id: I8a1b482beba37f01afbd20446d9e6f6125f2ec34
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5152
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 196 Anand Avati 2013-06-08 21:47:06 UTC
COMMIT: http://review.gluster.org/5153 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit 0a2f71d2fc8987e7226ae3ef7bc0cb05b5c53188
Author: Anand Avati <avati>
Date:   Tue Apr 23 13:59:12 2013 -0700

    syncop: set credentials of running process in @frame
    
    Inherit the pid/euid/egid/groups of the running process in the
    frame. Do this only in cases where a loaded frame was not
    presented to the synctask.
    
    This behavior is required for Samba VFS.
    
    Change-Id: Ib181c90f47c6741197b9ce9f67a19e2914b647d2
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5153
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 197 Anand Avati 2013-06-08 21:47:37 UTC
COMMIT: http://review.gluster.org/5154 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit 5b20fac94cd928747854c7170e368c6c864dff24
Author: Anand Avati <avati>
Date:   Tue Apr 23 14:20:13 2013 -0700

    gfapi: implement readdirplus_r support
    
    This call is used by Samba VFS.
    
    Change-Id: Ib371502ad5a71b3b0e993f6b30e3dfb1f839c020
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5154
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 198 Anand Avati 2013-06-08 21:49:45 UTC
COMMIT: http://review.gluster.org/5155 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit a7aa733d2802eee2f4f2d24eca4378997b89bfbb
Author: Anand Avati <avati>
Date:   Mon Apr 15 09:52:35 2013 -0700

    gfapi: POSIX locking support
    
    Change-Id: I37d9e1fb4a715094876be6af3856c1b4cf398021
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5155
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 199 Anand Avati 2013-06-08 21:50:18 UTC
COMMIT: http://review.gluster.org/5156 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit 84277d1a3002058c7e5991f96eb5d3b635ae87fc
Author: Anand Avati <avati>
Date:   Sat Apr 27 11:18:20 2013 -0700

    posix-acl: fetch ACLs in readdirplus
    
    Not fetching ACLs in readdirplus can potentially result in spurious
    wrong ACL decisions (which magically go away on a lookup() which
    populates the ACLs)
    
    Change-Id: Ided38b4d868fab482b477ce51b4878289ef9eed0
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5156
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 200 Anand Avati 2013-06-08 21:51:00 UTC
COMMIT: http://review.gluster.org/5157 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit 76f6dfdf50e9bb8905fc485e3519510e29e283be
Author: Anand Avati <avati>
Date:   Sat Apr 27 11:59:36 2013 -0700

    gfapi: add new API glfs_set_xlator_option()
    
    This is the equivalent of specifying --xlator-option command line
    argument to glusterfsd.
    
    Change-Id: I1171dd518a85db4bd456fa0790f450e889a956cd
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5157
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 201 Anand Avati 2013-06-08 21:51:35 UTC
COMMIT: http://review.gluster.org/5158 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit aa51ae9d99ac5ee10849392352743d6d92cfed9f
Author: Anand Avati <avati>
Date:   Sat May 18 20:35:30 2013 -0700

    quick-read: prune cache on write/[f]truncate
    
    Cache needs to be pruned on write and [f]truncate. The lack of this
    is causing Samba ping-pong test to return wierd 'data increment' values
    during startup.
    
    Change-Id: I9cd6a839bcd02de738d78638211b78f382f58e0a
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5158
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 202 Anand Avati 2013-06-08 21:52:08 UTC
COMMIT: http://review.gluster.org/5159 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit a3d7ab968438f4ef3440fdc4986fe5416a28e3cf
Author: Anand Avati <avati>
Date:   Sat Apr 27 21:40:19 2013 -0700

    gfapi: optimistic resolution with ESTALE detection
    
    Enhance the path resolver to be optimistic. Instead of performing
    a wasteful ->lookup() fop for every component in every API call,
    build in speculation logic to consider the previous resolution
    result temporarily, and if it results in ESTALE either later in
    the path resolution or in the FOP, then retry resolution with
    ->lookup() at every level and retry the FOP.
    
    This is the same optimistic resolution/retry logic Linux kernel
    resolver is proposing to use.
    
    Change-Id: Iecbc25248754caf0915cd7205910563ff88ce5e7
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5159
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 203 Anand Avati 2013-06-08 21:52:50 UTC
COMMIT: http://review.gluster.org/5160 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit d2370046c01aa20f00f5032a981579dd2d782c87
Author: Anand Avati <avati>
Date:   Sat Apr 27 11:40:02 2013 -0700

    md-cache: support negative xattr entries
    
    Add support for negative xattr caching. For this, we need
    to fetch xattrs in every opportunity (including readdirplus)
    in order to treat missing key in cached dict as negative entry.
    
    This is crucial to detect missing ACL xattrs in Samba workload.
    
    Change-Id: I918a2ef4ab804724256f7546b15e808332ed518d
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5160
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 204 Anand Avati 2013-06-08 21:53:22 UTC
COMMIT: http://review.gluster.org/5161 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit 9f6cb68802c197cc9b788a589c97c8bb71be2804
Author: Anand Avati <avati>
Date:   Sun Apr 28 02:01:01 2013 -0700

    syncop: copy inode pointer in readdirplus
    
    Change-Id: I9ab2b8ac2da9fe13f56b8b08f715a0b603ece0cb
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5161
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 205 Anand Avati 2013-06-08 21:53:55 UTC
COMMIT: http://review.gluster.org/5162 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit 40b3bf9c15d4144fa768df061fbbbd15f9e8c8fc
Author: Anand Avati <avati>
Date:   Sun Apr 28 12:22:54 2013 -0700

    gfapi: link inodes in relevant entry FOPs
    
    Do not let inode linking to happen only in lookup(). While
    that works, it is inefficient.
    
    Change-Id: I51bbfb6255ec4324ab17ff00566375f49d120c06
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5162
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 206 Anand Avati 2013-06-08 21:54:26 UTC
COMMIT: http://review.gluster.org/5163 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit 6646c700c7c2b6194ace08cf35a63c54693f7ade
Author: Anand Avati <avati>
Date:   Thu May 2 08:00:22 2013 -0700

    dht,posix: support for case discovery
    
    This is support for discovering a filename in a given directory
    which has a case insensitive match of a given name. It is implemented
    as a virtual extended attribute on the directory where the required
    filename is specified in the key.
    
    E.g:
    
      sh# getfattr -e "text" -n user.glusterfs.get_real_filename:FiLe-B /mnt/samba/patchy
      getfattr: Removing leading '/' from absolute path names
      # file: mnt/samba/patchy
      user.glusterfs.get_real_filename:FiLe-B="file-b"
    
    In reality, there can be multiple "answers" as the backend filesystem is
    case sensitive and there can be multiple files which can strcasecamp()
    successfully. In this case we pick the first matched file from the first
    responding server.
    
    If a matching file does not exist, we return ENOENT (and NOT ENODATA).
    This way the caller can differentiate between "unsupported" glusterfs
    API and file not existing.
    
    This API is used by Samba VFS to perform efficient discovery of the real
    filename without doing a full scan at the Samba level.
    
    Change-Id: I53054c4067cba69e585fd0bbce004495bc6e39e8
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5163
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 207 Anand Avati 2013-06-08 21:54:57 UTC
COMMIT: http://review.gluster.org/5164 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit 54ea75f800b9158083bd5d7f6316fd814d0deaf9
Author: Anand Avati <avati>
Date:   Sun May 19 23:31:38 2013 -0700

    gfapi: provide stable st_dev in stat structure
    
    Samba depends on st_dev being unique and stable for different
    filesystems (it uses st_dev+st_ino as key to store metadata of
    a file).
    
    Change-Id: Ia022fabadfb5ef3fc9724c1b1ca86f1a20f98af9
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5164
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Xavier Hernandez <xhernandez>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 208 Anand Avati 2013-06-08 21:55:27 UTC
COMMIT: http://review.gluster.org/5165 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit 481170939e445d6592621a4ea56b3fb437579226
Author: Anand Avati <avati>
Date:   Wed Apr 24 00:51:12 2013 -0700

    pkg-config: present API version and not package version
    
    This way PKG_MODULE() autoconf test checks for required API
    rather than release version (e.g required API could be in all
    all of 3.4.5, 3.5.1, 3.6.4 etc.)
    
    With the first "release" of gfapi, the current version (4) will
    be frozen.
    
    Version 3 is sufficient for QEMU's requirement. Version 4 is
    necessary for Samba VFS
    
    Change-Id: Iada3a4c88b9c67413dcd57004fd8a62926a21b42
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5165
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 209 Anand Avati 2013-06-08 21:55:57 UTC
COMMIT: http://review.gluster.org/5166 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit 40845920cce55c4be0bb5187e820f9a92b92929c
Author: Anand Avati <avati>
Date:   Thu May 23 23:14:30 2013 -0700

    gfapi: ignore NULL and -1 parameters in glfs_set_logging()
    
    Permit changing either logfile or level by specifying the other
    as -1 or NULL respectively.
    
    Change-Id: I7df05db7b613c57e0106a5cce846ae26d2a160d4
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5166
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Xavier Hernandez <xhernandez>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 210 Anand Avati 2013-06-08 21:56:28 UTC
COMMIT: http://review.gluster.org/5167 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit 8946bd7d239dc505d53270e29684ccf9df9ce3a0
Author: Anand Avati <avati>
Date:   Tue May 21 16:27:09 2013 -0700

    gfapi: handle graph switch (cwd, fds, locks)
    
    - Migrate open fds to new graph
    - Migrate locks held in open fd to new fd
    - Refresh CWD, so resolution of relative paths happens on refreshed
      inode (on new graph).
    
    Change-Id: I4b18083b9b290107ebda1f917fc85b635ab72fb4
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5167
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 211 Anand Avati 2013-06-08 21:56:59 UTC
COMMIT: http://review.gluster.org/5168 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit c8611f9a1d5e486333383ba1531757bf8fd49458
Author: Anand Avati <avati>
Date:   Wed May 29 03:12:19 2013 -0700

    socket: convert socket functions to file scope (static)
    
    The function names used in socket.c conflict with Samba's
    socket functions (samba.git/source4/lib/socket/socket.h). Convert
    our functions to file scope as they are anyways not called across
    files.
    
    Change-Id: If98ae557d3e2868f257c021b283ede6a5e92de02
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5168
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 212 Anand Avati 2013-06-08 21:57:29 UTC
COMMIT: http://review.gluster.org/5169 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit d660b5fe4402d8942dfe6d3e5cecba9c1e0c297f
Author: Anand Avati <avati>
Date:   Wed May 29 03:15:19 2013 -0700

    api/Makefile: link api.so against libgfapi (and dependencies)
    
    Samba opens vfs_gluster.so with dlopen(..,RTLD_LOCAL). This makes
    the symobls in the shared module and the library it exclusively
    links against (specifically gfapi) not resolvable from the .so
    files which are opened in turn within (like xlator .so files)
    unless explicitly linked against the dependent libraries.
    
    This is not otherwise required in case of glusterfsd as the main
    executable symbols are always available for resolution from
    dlopen()'ed shared objects, making Samba's vfs_glusterfs
    requirement unique, but luckily not incompatible.
    
    Change-Id: I894c521daade7d46ec5bf07793f2eea02ebc9700
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5169
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 213 Anand Avati 2013-06-08 21:58:00 UTC
COMMIT: http://review.gluster.org/5170 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit e25cf30a74941b4dc76b6d26b602afec2c1e2c6e
Author: Anand Avati <avati>
Date:   Thu May 2 20:01:18 2013 -0700

    gfapi: add new API glfs_dup() to copy a file descriptor
    
    Duplicate a glfs_fd file descriptor. Inherit the internal
    fd_t with a reference.
    
    Change-Id: Ib30e9a46b608b9f78202957f4dab6ba6265a9ec0
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5170
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 214 Anand Avati 2013-06-08 21:58:30 UTC
COMMIT: http://review.gluster.org/5171 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit 0f741cec5f031dc1c6e1b96e0f5c35d0f374af4d
Author: Anand Avati <avati>
Date:   Fri May 3 05:44:17 2013 -0700

    api: Fix api.so and libgfapi.so build time dependency
    
    Not all versions of autoconf handle dependencies expressed
    as "A: B". Use the xxx_DEPENDENCIES variable to make it
    version independent
    
    Change-Id: Ia0b13399d0bf10995d9845e04cd9eb3ef6518dbe
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5171
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 215 Anand Avati 2013-06-19 06:00:24 UTC
REVIEW: http://review.gluster.org/5236 (gfapi: fix read past EOF in glfs_preadv()) posted (#2) for review on master by Anand Avati (avati)

Comment 216 Anand Avati 2013-06-19 06:00:59 UTC
REVIEW: http://review.gluster.org/5237 (gfapi: fix read past EOF in glfs_preadv()) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 217 Anand Avati 2013-06-19 19:40:37 UTC
REVIEW: http://review.gluster.org/5236 (gfapi: fix read past EOF in glfs_preadv()) posted (#3) for review on master by Anand Avati (avati)

Comment 218 Anand Avati 2013-06-19 19:43:21 UTC
REVIEW: http://review.gluster.org/5237 (gfapi: fix read past EOF in glfs_preadv()) posted (#2) for review on release-3.4 by Anand Avati (avati)

Comment 219 Anand Avati 2013-06-20 08:46:27 UTC
COMMIT: http://review.gluster.org/5236 committed in master by Vijay Bellur (vbellur) 
------
commit d7e80787fc61a4fe9e72ff80565dc720ac29441a
Author: Anand Avati <avati>
Date:   Sun Jun 16 06:19:52 2013 -0700

    gfapi: fix read past EOF in glfs_preadv()
    
    When syncop_preadv() returns 0, we are returning @size as-is
    (without modifying user passed buffer). This results in
    junk data being read when read offset is at or beyond EOF.
    
    Change-Id: I8aa9c957359f9a52833b944b452f501b6f5538d3
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5236
    Reviewed-by: Raghavendra Talur <rtalur>
    Reviewed-by: José Rivera <jrivera>
    Tested-by: José Rivera <jrivera>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 220 Anand Avati 2013-06-20 08:47:04 UTC
COMMIT: http://review.gluster.org/5237 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit cc477c7da1b543d51939aba919155a651099d4ba
Author: Anand Avati <avati>
Date:   Sun Jun 16 06:19:52 2013 -0700

    gfapi: fix read past EOF in glfs_preadv()
    
    When syncop_preadv() returns 0, we are returning @size as-is
    (without modifying user passed buffer). This results in
    junk data being read when read offset is at or beyond EOF.
    
    Change-Id: I8aa9c957359f9a52833b944b452f501b6f5538d3
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5237
    Reviewed-by: Raghavendra Talur <rtalur>
    Reviewed-by: José Rivera <jrivera>
    Tested-by: José Rivera <jrivera>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 221 Anand Avati 2013-06-23 22:28:26 UTC
REVIEW: http://review.gluster.org/5247 (extras/hook-scripts: Set of changes for new samba share method.) posted (#1) for review on master by Raghavendra Talur (rtalur)

Comment 222 Anand Avati 2013-06-27 13:28:20 UTC
REVIEW: http://review.gluster.org/5247 (extras/hook-scripts: Set of changes for new samba share method.) posted (#2) for review on master by Raghavendra Talur (rtalur)

Comment 223 Anand Avati 2013-06-28 16:25:42 UTC
COMMIT: http://review.gluster.org/5247 committed in master by Vijay Bellur (vbellur) 
------
commit ac62c953e499dca873fbf808b95df0feb50bda27
Author: Raghavendra Talur <rtalur>
Date:   Mon Jun 24 02:57:07 2013 +0530

    extras/hook-scripts: Set of changes for new samba share method.
    
    New method of creating a share of gluster volume
    through samba eliminates the requirement of fuse
    mount and changes in fstab.
    
    glusterfs vfs plugin has to be specified as required
    vfs object.
    Path now is relative to the root of gluster volume.
    / signifies complete volume.
    
    Change-Id: I3d80452cd58513ef59d6a816c1ab62ebc3b76a62
    BUG: 953694
    Signed-off-by: Raghavendra Talur <rtalur>
    Reviewed-on: http://review.gluster.org/5247
    Reviewed-by: José Rivera <jrivera>
    Tested-by: José Rivera <jrivera>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 224 Anand Avati 2013-07-03 06:15:29 UTC
REVIEW: http://review.gluster.org/5276 (api: Bump version to 5.) posted (#1) for review on master by Vijay Bellur (vbellur)

Comment 225 Anand Avati 2013-07-05 06:36:57 UTC
COMMIT: http://review.gluster.org/5276 committed in master by Vijay Bellur (vbellur) 
------
commit 9e687332b4900cf4c91a4cf9b34da8d2a97e39df
Author: Vijay Bellur <vbellur>
Date:   Wed Jul 3 10:24:50 2013 +0530

    api: Bump version to 5.
    
    version 5 adds support for fallocate & discard.
    
    Change-Id: Ifdc226953a25e4a4eb63e55d2a7c7ec77c397215
    BUG: 953694
    Signed-off-by: Vijay Bellur <vbellur>
    Reviewed-on: http://review.gluster.org/5276
    Reviewed-by: Bharata B Rao <bharata.rao>
    Tested-by: Gluster Build System <jenkins.com>

Comment 226 Anand Avati 2013-07-16 10:38:41 UTC
REVIEW: http://review.gluster.org/5333 (gfapi: fix for not able to rename folders) posted (#1) for review on master by Raghavendra Talur (rtalur)

Comment 227 Anand Avati 2013-07-16 22:59:25 UTC
COMMIT: http://review.gluster.org/5333 committed in master by Anand Avati (avati) 
------
commit da50f61174dad89699da40212746b398b576ca15
Author: Raghavendra Talur <rtalur>
Date:   Tue Jul 16 15:58:03 2013 +0530

    gfapi: fix for not able to rename folders
    
    If oldname is being renamed to newname, we need to
    check for type of newname only if newname exists.
    
    Change-Id: I068a283f9ffe67fcd5e8754d6bf052a2339efbf2
    BUG: 953694
    Signed-off-by: Raghavendra Talur <rtalur>
    Reviewed-on: http://review.gluster.org/5333
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>

Comment 228 Anand Avati 2013-07-23 10:56:06 UTC
REVIEW: http://review.gluster.org/5172 (core: increase the auxillary group limit to 65536) posted (#2) for review on release-3.4 by Anand Avati (avati)

Comment 229 Anand Avati 2013-07-23 10:57:00 UTC
REVIEW: http://review.gluster.org/5111 (core: increase the auxillary group limit to 65536) posted (#4) for review on master by Anand Avati (avati)

Comment 230 Anand Avati 2013-07-23 11:40:01 UTC
REVIEW: http://review.gluster.org/5111 (core: increase the auxillary group limit to 65536) posted (#5) for review on master by Anand Avati (avati)

Comment 231 Anand Avati 2013-07-23 11:44:53 UTC
REVIEW: http://review.gluster.org/5172 (core: increase the auxillary group limit to 65536) posted (#3) for review on release-3.4 by Anand Avati (avati)

Comment 232 Anand Avati 2013-07-24 18:37:24 UTC
COMMIT: http://review.gluster.org/5111 committed in master by Vijay Bellur (vbellur) 
------
commit 7cfef511898ba2d555256e6d7f53bd97ed69e6e0
Author: Anand Avati <avati>
Date:   Thu May 2 23:36:01 2013 -0700

    core: increase the auxillary group limit to 65536
    
    Make the allocation of groups dynamic and increase the limit
    to 65536.
    
    Change-Id: I702364ff460e3a982e44ccbcb3e337cac9c2df51
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5111
    Reviewed-by: Xavier Hernandez <xhernandez>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 233 Anand Avati 2013-07-28 03:59:15 UTC
REVIEW: http://review.gluster.org/5407 (gfapi: handle failures in graph switches) posted (#1) for review on master by Anand Avati (avati)

Comment 234 Anand Avati 2013-07-28 15:20:57 UTC
COMMIT: http://review.gluster.org/5407 committed in master by Vijay Bellur (vbellur) 
------
commit aa70c0bba081b7a56a3894c5454a78b27753bdff
Author: Anand Avati <avati>
Date:   Sun Jul 21 00:43:18 2013 -0700

    gfapi: handle failures in graph switches
    
    A graph switch failure can potentially result in NULL returned
    for glfs_active_subvol(). Handle this gracefully in glfs_subvol_done()
    
    Change-Id: I6adbd878c354b9ed2314fc71cea4671792efa0a4
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5407
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 235 Anand Avati 2013-07-30 07:02:54 UTC
REVIEW: http://review.gluster.org/5426 (api: Avoid a NULL deref in glfs_open()) posted (#1) for review on master by Vijay Bellur (vbellur)

Comment 236 Anand Avati 2013-07-30 09:38:14 UTC
REVIEW: http://review.gluster.org/5427 (gfapi: handle failures in graph switches) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 237 Anand Avati 2013-07-30 15:41:34 UTC
REVIEW: http://review.gluster.org/5426 (api: Avoid a NULL deref in glfs_open().) posted (#2) for review on master by Vijay Bellur (vbellur)

Comment 238 Anand Avati 2013-07-31 02:51:30 UTC
COMMIT: http://review.gluster.org/5426 committed in master by Anand Avati (avati) 
------
commit 0bbdfa3d403a90fa0f30e0e5bd56644c875c12c1
Author: Vijay Bellur <vbellur>
Date:   Tue Jul 30 12:29:35 2013 +0530

    api: Avoid a NULL deref in glfs_open().
    
    Change-Id: I23e9fabcb8a430bcd44595ca31460c54d7bd4a39
    BUG: 953694
    Signed-off-by: Vijay Bellur <vbellur>
    Reviewed-on: http://review.gluster.org/5426
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>

Comment 239 Anand Avati 2013-07-31 05:18:15 UTC
COMMIT: http://review.gluster.org/5427 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit ccb48ebfafba7ba50d3fb156ecd8ba9666577fd2
Author: Anand Avati <avati>
Date:   Sun Jul 21 00:43:18 2013 -0700

    gfapi: handle failures in graph switches
    
    A graph switch failure can potentially result in NULL returned
    for glfs_active_subvol(). Handle this gracefully in glfs_subvol_done()
    
    Change-Id: I6adbd878c354b9ed2314fc71cea4671792efa0a4
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5427
    Reviewed-by: Vijay Bellur <vbellur>
    Tested-by: Gluster Build System <jenkins.com>

Comment 240 Anand Avati 2013-07-31 06:40:59 UTC
REVIEW: http://review.gluster.org/5439 (gfapi: fix glfs_readlink()) posted (#1) for review on master by Anand Avati (avati)

Comment 241 Anand Avati 2013-07-31 06:51:28 UTC
REVIEW: http://review.gluster.org/5439 (gfapi: fix glfs_readlink()) posted (#2) for review on master by Anand Avati (avati)

Comment 242 Anand Avati 2013-07-31 13:24:17 UTC
COMMIT: http://review.gluster.org/5439 committed in master by Anand Avati (avati) 
------
commit 21d032bf052957b50043f5f3775903d9d7f029c3
Author: Anand Avati <avati>
Date:   Mon Jul 22 01:15:21 2013 -0700

    gfapi: fix glfs_readlink()
    
    glfs_readlink() is supposed to memcpy the buffer pointer
    returned by syncop_readlink(). Fix it.
    
    Change-Id: I5936b07abbd93cf02b354233dc60f6623e30a38b
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5439
    Reviewed-by: Amar Tumballi <amarts>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra Talur <rtalur>

Comment 243 Raghavendra Talur 2013-08-16 06:17:26 UTC
This is a tracker bug. Closing this as the requirements are in place.

Comment 244 Anand Avati 2013-08-16 18:40:59 UTC
REVIEW: http://review.gluster.org/5640 (md-cache: invalidate attributes on xattr update) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 245 Anand Avati 2013-08-16 21:12:27 UTC
REVIEW: http://review.gluster.org/5641 (md-cache: invalidate attributes on xattr update) posted (#1) for review on master by Anand Avati (avati)

Comment 246 Anand Avati 2013-08-18 23:03:25 UTC
REVIEW: http://review.gluster.org/5649 (cluster/dht: DHT_IS_DIR needs a NULL check) posted (#1) for review on master by Harshavardhana (harsha)

Comment 247 Anand Avati 2013-08-18 23:07:09 UTC
REVIEW: http://review.gluster.org/5649 (cluster/dht: DHT_IS_DIR needs a NULL check) posted (#2) for review on master by Harshavardhana (harsha)

Comment 248 Anand Avati 2013-08-19 16:55:05 UTC
REVIEW: http://review.gluster.org/5641 (md-cache: invalidate attributes on xattr update) posted (#2) for review on master by Anand Avati (avati)

Comment 249 Anand Avati 2013-08-19 17:34:03 UTC
REVIEW: http://review.gluster.org/5641 (md-cache: invalidate attributes on xattr update) posted (#3) for review on master by Anand Avati (avati)

Comment 250 Anand Avati 2013-08-20 06:04:07 UTC
COMMIT: http://review.gluster.org/5641 committed in master by Vijay Bellur (vbellur) 
------
commit a232deaa82c561013d66322afdc1de1f526ecbd4
Author: Anand Avati <avati>
Date:   Sat Aug 10 16:10:26 2013 -0700

    md-cache: invalidate attributes on xattr update
    
    xattr update will result in at least ctime change. So invalidate
    attributes in xattr callback.
    
    Change-Id: Ie6e8f2fd9a11c56c27e78bd58c2ff1e1d6edce6e
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5641
    Reviewed-by: Amar Tumballi <amarts>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 251 Anand Avati 2013-09-05 10:35:24 UTC
REVIEW: http://review.gluster.org/5640 (md-cache: invalidate attributes on xattr update) posted (#2) for review on release-3.4 by Vijay Bellur (vbellur)

Comment 252 Anand Avati 2013-09-05 15:08:35 UTC
REVIEW: http://review.gluster.org/5640 (md-cache: invalidate attributes on xattr update) posted (#3) for review on release-3.4 by Vijay Bellur (vbellur)

Comment 253 Anand Avati 2013-09-06 04:22:43 UTC
REVIEW: http://review.gluster.org/5640 (md-cache: invalidate attributes on xattr update) posted (#4) for review on release-3.4 by Vijay Bellur (vbellur)

Comment 254 Anand Avati 2013-09-06 07:38:45 UTC
REVIEW: http://review.gluster.org/5640 (md-cache: invalidate attributes on xattr update) posted (#5) for review on release-3.4 by Vijay Bellur (vbellur)

Comment 255 Anand Avati 2013-09-07 14:56:43 UTC
REVIEW: http://review.gluster.org/5640 (md-cache: invalidate attributes on xattr update) posted (#6) for review on release-3.4 by Vijay Bellur (vbellur)

Comment 256 Anand Avati 2013-09-08 13:59:45 UTC
COMMIT: http://review.gluster.org/5640 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit 7ad7c0171cb8341ac8293c6b01313e2eac8bab07
Author: Anand Avati <avati>
Date:   Sat Aug 10 16:10:26 2013 -0700

    md-cache: invalidate attributes on xattr update
    
    xattr update will result in at least ctime change. So invalidate
    attributes in xattr callback.
    
    Change-Id: Ie6e8f2fd9a11c56c27e78bd58c2ff1e1d6edce6e
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5641
    Reviewed-by: Amar Tumballi <amarts>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>
    Reviewed-on: http://review.gluster.org/5640

Comment 257 Anand Avati 2013-09-10 00:29:23 UTC
COMMIT: http://review.gluster.org/5172 committed in release-3.4 by Anand Avati (avati) 
------
commit 8eb866cc0c3ed17f7cd9ca7d6cfc3dc3de140835
Author: Anand Avati <avati>
Date:   Thu May 2 23:36:01 2013 -0700

    core: increase the auxillary group limit to 65536
    
    Make the allocation of groups dynamic and increase the limit
    to 65536.
    
    Change-Id: I702364ff460e3a982e44ccbcb3e337cac9c2df51
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5172
    Reviewed-by: Xavier Hernandez <xhernandez>
    Tested-by: Gluster Build System <jenkins.com>

Comment 258 Anand Avati 2013-09-10 00:57:08 UTC
REVIEW: http://review.gluster.org/5885 (gfapi: fix glfs_readlink()) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 259 Anand Avati 2013-09-10 00:57:37 UTC
REVIEW: http://review.gluster.org/5886 (gfapi: fix for not able to rename folders) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 260 Anand Avati 2013-09-10 01:10:35 UTC
REVIEW: http://review.gluster.org/5886 (gfapi: fix for not able to rename folders) posted (#2) for review on release-3.4 by Anand Avati (avati)

Comment 261 Anand Avati 2013-09-10 01:11:03 UTC
REVIEW: http://review.gluster.org/5885 (gfapi: fix glfs_readlink()) posted (#2) for review on release-3.4 by Anand Avati (avati)

Comment 262 Anand Avati 2013-09-10 08:26:47 UTC
COMMIT: http://review.gluster.org/5885 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit 5159d29cf36153d874ee446805419c864c1ba1ee
Author: Anand Avati <avati>
Date:   Mon Jul 22 01:15:21 2013 -0700

    gfapi: fix glfs_readlink()
    
    glfs_readlink() is supposed to memcpy the buffer pointer
    returned by syncop_readlink(). Fix it.
    
    Change-Id: I5936b07abbd93cf02b354233dc60f6623e30a38b
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/5885
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 263 Anand Avati 2013-09-10 08:27:28 UTC
COMMIT: http://review.gluster.org/5886 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit a3a704f369440d42acd0eb8d86cd07e2852980b7
Author: Raghavendra Talur <rtalur>
Date:   Tue Jul 16 15:58:03 2013 +0530

    gfapi: fix for not able to rename folders
    
    If oldname is being renamed to newname, we need to
    check for type of newname only if newname exists.
    
    Change-Id: I068a283f9ffe67fcd5e8754d6bf052a2339efbf2
    BUG: 953694
    Signed-off-by: Raghavendra Talur <rtalur>
    Reviewed-on: http://review.gluster.org/5886
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 264 Anand Avati 2013-09-14 19:57:24 UTC
REVIEW: http://review.gluster.org/5927 (rpcsvc: allocate large auxgid list on demand) posted (#1) for review on master by Anand Avati (avati)

Comment 265 Anand Avati 2013-09-14 19:59:36 UTC
REVIEW: http://review.gluster.org/5928 (rpcsvc: allocate large auxgid list on demand) posted (#1) for review on release-3.4 by Anand Avati (avati)

Comment 266 Anand Avati 2013-09-14 22:48:20 UTC
REVIEW: http://review.gluster.org/5928 (rpcsvc: allocate large auxgid list on demand) posted (#2) for review on release-3.4 by Anand Avati (avati)

Comment 267 Anand Avati 2013-09-17 18:45:07 UTC
COMMIT: http://review.gluster.org/5927 committed in master by Anand Avati (avati) 
------
commit 5ab18374d07c57de5647682d51afa05101be356f
Author: Anand Avati <avati>
Date:   Thu Sep 12 08:16:40 2013 -0700

    rpcsvc: allocate large auxgid list on demand
    
    For rpc requests having large aux group list, allocate large list
    on demand. Else use small static array by default.
    
    Without this patch, glusterfsd allocates 140+MB of resident memory
    just to get started and initialized.
    
    Change-Id: I3a07212b0076079cff67cdde18926e8f3b196258
    Signed-off-by: Anand Avati <avati>
    BUG: 953694
    Reviewed-on: http://review.gluster.org/5927
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Amar Tumballi <amarts>

Comment 268 Anand Avati 2013-09-19 17:27:35 UTC
REVIEW: http://review.gluster.org/5928 (rpcsvc: allocate large auxgid list on demand) posted (#3) for review on release-3.4 by Vijay Bellur (vbellur)

Comment 269 Anand Avati 2013-09-19 21:07:18 UTC
COMMIT: http://review.gluster.org/5928 committed in release-3.4 by Anand Avati (avati) 
------
commit 0af0e6405d6911cf41d1ad1d4504baa842c1328e
Author: Anand Avati <avati>
Date:   Thu Sep 12 08:16:40 2013 -0700

    rpcsvc: allocate large auxgid list on demand
    
    For rpc requests having large aux group list, allocate large list
    on demand. Else use small static array by default.
    
    Without this patch, glusterfsd allocates 140+MB of resident memory
    just to get started and initialized.
    
    Change-Id: I3a07212b0076079cff67cdde18926e8f3b196258
    Signed-off-by: Anand Avati <avati>
    BUG: 953694
    Reviewed-on: http://review.gluster.org/5927
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Amar Tumballi <amarts>
    Reviewed-on: http://review.gluster.org/5928

Comment 270 Anand Avati 2013-10-18 19:08:21 UTC
REVIEW: http://review.gluster.org/6111 (gfapi: wake migration waiters after migration) posted (#1) for review on master by Anand Avati (avati)

Comment 271 Anand Avati 2013-10-22 16:33:45 UTC
COMMIT: http://review.gluster.org/6111 committed in master by Anand Avati (avati) 
------
commit 7ebcf96c94c1292dcc7155c74b49257a9952b8d4
Author: Anand Avati <avati>
Date:   Sun Oct 13 23:15:48 2013 -0700

    gfapi: wake migration waiters after migration
    
    Wake call threads which are waiting on migration to complete with
    a cond_broadcast. Else if any call which arrives right when migration
    is attempted will end up hanging indefinitely.
    
    Change-Id: I7df5298f93998d9a54fb12c16654e62333018ece
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/6111
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra Bhat <raghavendra>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 272 Anand Avati 2013-10-24 03:36:10 UTC
REVIEW: http://review.gluster.org/6131 (gfapi: remove unnecessary call to glfs_resolve_base()) posted (#1) for review on master by Anand Avati (avati)

Comment 273 Anand Avati 2013-10-31 15:56:37 UTC
REVIEW: http://review.gluster.org/6131 (gfapi: remove unnecessary call to glfs_resolve_base()) posted (#2) for review on master by Anand Avati (avati)

Comment 274 Anand Avati 2013-11-08 07:56:05 UTC
COMMIT: http://review.gluster.org/6131 committed in master by Vijay Bellur (vbellur) 
------
commit c80794079a246f4fee730d028350e80c38dbf034
Author: Anand Avati <avati>
Date:   Mon Oct 21 20:29:07 2013 -0700

    gfapi: remove unnecessary call to glfs_resolve_base()
    
    Calling glfs_resolve_base() on the root inode for every resolver
    invocation is unnecessary and wasteful.
    
    Here are the results from running a test program which performs
    path based operations (creates and deletes 1000 files):
    
    Without patch:
    [root@blackbox ~]# sync
    [root@blackbox ~]# time ./a.out 1
    
    real    0m4.314s
    user    0m1.923s
    sys     0m1.144s
    [root@blackbox ~]# sync
    [root@blackbox ~]# time ./a.out 1
    
    real    0m4.383s
    user    0m1.940s
    sys     0m1.177s
    [root@blackbox ~]# sync
    [root@blackbox ~]# time ./a.out 1
    
    real    0m4.339s
    user    0m1.863s
    sys     0m1.129s
    
    With patch:
    
    [root@blackbox ~]# sync
    [root@blackbox ~]# time ./a.out 1
    
    real    0m3.005s
    user    0m1.162s
    sys     0m0.816s
    [root@blackbox ~]# sync
    [root@blackbox ~]# time ./a.out 1
    
    real    0m3.188s
    user    0m1.222s
    sys     0m0.867s
    [root@blackbox ~]# sync
    [root@blackbox ~]# time ./a.out 1
    
    real    0m2.999s
    user    0m1.131s
    sys     0m0.832s
    
    Change-Id: Id160a24f44b4dccfcfce99a6f69ddb8938523cd5
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/6131
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra Talur <rtalur>
    Reviewed-by: Raghavendra Bhat <raghavendra>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 275 Anand Avati 2013-11-26 18:38:36 UTC
COMMIT: http://review.gluster.org/6323 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit a15edf06b1cf481b459bfc4ee346624b688f6b7d
Author: Anand Avati <avati>
Date:   Sun Oct 13 23:15:48 2013 -0700

    gfapi: wake migration waiters after migration
    
    Wake call threads which are waiting on migration to complete with
    a cond_broadcast. Else if any call which arrives right when migration
    is attempted will end up hanging indefinitely.
    
    Change-Id: I7df5298f93998d9a54fb12c16654e62333018ece
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/6323
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 276 Anand Avati 2013-11-26 19:02:24 UTC
COMMIT: http://review.gluster.org/6321 committed in release-3.4 by Anand Avati (avati) 
------
commit 28ae39e94092ce853a114ee9186fbf8f0f1e6adb
Author: Anand Avati <avati>
Date:   Mon Oct 21 20:29:07 2013 -0700

    gfapi: remove unnecessary call to glfs_resolve_base()
    
    Calling glfs_resolve_base() on the root inode for every resolver
    invocation is unnecessary and wasteful.
    
    Here are the results from running a test program which performs
    path based operations (creates and deletes 1000 files):
    
    Without patch:
    [root@blackbox ~]# sync
    [root@blackbox ~]# time ./a.out 1
    
    real    0m4.314s
    user    0m1.923s
    sys     0m1.144s
    [root@blackbox ~]# sync
    [root@blackbox ~]# time ./a.out 1
    
    real    0m4.383s
    user    0m1.940s
    sys     0m1.177s
    [root@blackbox ~]# sync
    [root@blackbox ~]# time ./a.out 1
    
    real    0m4.339s
    user    0m1.863s
    sys     0m1.129s
    
    With patch:
    
    [root@blackbox ~]# sync
    [root@blackbox ~]# time ./a.out 1
    
    real    0m3.005s
    user    0m1.162s
    sys     0m0.816s
    [root@blackbox ~]# sync
    [root@blackbox ~]# time ./a.out 1
    
    real    0m3.188s
    user    0m1.222s
    sys     0m0.867s
    [root@blackbox ~]# sync
    [root@blackbox ~]# time ./a.out 1
    
    real    0m2.999s
    user    0m1.131s
    sys     0m0.832s
    
    Change-Id: Id160a24f44b4dccfcfce99a6f69ddb8938523cd5
    BUG: 953694
    Signed-off-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/6321
    Tested-by: Gluster Build System <jenkins.com>


Note You need to log in before you can comment on or make changes to this bug.