Chromium Main Console
Legend: | Passed | Failed | Running | Exception |
Reland "Add presubmit error when adding new download from google storage hook"
This is a reland of commit 729bfb6635ddb64f7db779483818061b14408597
What's changed: Previously it was picking up affected files from paths
that end in DEPS, such as chrome/test/DEPS, because it was extracting
the basename. Changed it to look at the full path so it should only
analyze changes from src/DEPS.
Original change's description:
> Add presubmit error when adding new download from google storage hook
>
> If a user adds a new hook using the download_from_google_storage
> script, presubmit will error and tell the user to add it as a first
> class dep instead.
>
> Bug: b/324418194
> Change-Id: Id074b36d341f9ebadbb5301b36203f3b8122174e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5447679
> Reviewed-by: Joanna Wang <jojwang@chromium.org>
> Commit-Queue: Stephanie Kim <kimstephanie@google.com>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Cr-Commit-Position: refs/heads/main@{#1289381}
Bug: b/324418194
Change-Id: Ifbdd55c0db2b8d306f5edce7dc973c2a5ef46ed1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472455
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/main@{#1291938}
Roll src-internal from c30d1c570e11 to 00452eb77fe2 (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c30d1c570e11..00452eb77fe2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,jihadghanna@google.com,mcnee@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:40074070
Tbr: jihadghanna@google.com,mcnee@google.com
Change-Id: Ife5f4c8bf83a577e87ccf20e91f4fe19bb1caa50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5482894
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291937}
Roll V8 from e344a9dbca61 to ff86004b1caf (13 revisions)
https://chromium.googlesource.com/v8/v8.git/+log/e344a9dbca61..ff86004b1caf
2024-04-24 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 12.6.90
2024-04-24 dmercadier@chromium.org [turboshaft] Maglev-to-ts: support inner functions
2024-04-24 dmercadier@chromium.org [turboshaft] Maglev-to-ts: fix bug in Number equality
2024-04-24 dmercadier@chromium.org [turboshaft] Maglev-to-ts: support const-tracking let
2024-04-24 saelo@chromium.org [sandbox] Add mjsunit tests for the memory corruption API
2024-04-24 dlehmann@chromium.org [wasm] Add test for call_ref inlining feedback
2024-04-24 victorgomes@chromium.org [maglev] Fix bug else-if condition in phi reprentation selector
2024-04-24 saelo@chromium.org [sandbox] Fix stack out-of-bounds read in ArrayPrototypePush
2024-04-24 thibaudm@chromium.org [wasm][jspi] Add missing return statement
2024-04-24 dlehmann@chromium.org [wasm] Update trace output in test for Turboshaft
2024-04-24 jkummerow@chromium.org [gm.py] Avoid creating empty lines in args.gn
2024-04-24 jasnell@gmail.com Implement v8::Exception::CaptureStackTrace(...)
2024-04-24 jkummerow@chromium.org [wasm-fuzzer-gen-test] Use type codes where appropriate
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/v8-chromium-autoroll
Please CC liviurau@google.com,machenbach@google.com,v8-waterfall-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:dawn-linux-x64-deps-rel
Change-Id: I997b9ead4bd286c100de2f86d88a5454eb15ddba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5482899
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291936}
Revert "jni_zero: Fixing up more broken multiplexing instances"
This reverts commit 43c68b0aadee5aea59b467daefeb1572e694240a.
Reason for revert: Breaks internal build
See https://ci.chromium.org/ui/p/chrome/builders/ci/chromium-internal-arm-builder-rel/9905/overview
java.io.IOException: error reading obj/ui/base/select_file_dialog_jni_headers_java.processed.jar
at com.google.turbine.binder.ClassPathBinder.bindClasspath(ClassPathBinder.java:69)
at com.google.turbine.main.Main.bind(Main.java:272)
at com.google.turbine.main.Main.compile(Main.java:158)
at com.google.turbine.main.Main.compile(Main.java:133)
at com.google.turbine.main.Main.main(Main.java:89)
Caused by: java.nio.file.NoSuchFileException: obj/ui/base/select_file_dialog_jni_headers_java.processed.jar
Original change's description:
> jni_zero: Fixing up more broken multiplexing instances
>
> These are a non-exhaustive set of cases where multiplexing broke
> because we are depending on a generate_jni target without depending on
> the corresponding .cc file which includes the _jni.h file.
>
>
> Bug: 40612925
> Change-Id: I9ce6261998ab0614ee33ba0895b9dee510ce02f7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5478018
> Owners-Override: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Sam Maier <smaier@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1291845}
Bug: 40612925
Change-Id: If966d17bbd232f683d1c2e2beae9035890aa1f5e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5483669
Auto-Submit: Patrick Noland <pnoland@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291935}
Use Accept as CloseReason from Default Browser settings
When user sets their browser as default from settings we should remove
the set default browser menu item. This isn't currently happening because we pass in Dismiss as the CloseReason. This change addresses
this issue.
Bug: 336801614
Change-Id: I492bb09d2b834d0614e642b774fbe1eee768c628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5480669
Reviewed-by: Alison Gale <agale@chromium.org>
Commit-Queue: Eshwar Stalin <estalin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291934}
Remove redundant code in password_form html file
Bug: 336449363
Change-Id: Ia038f0f2e453b69f66850ebb77d52ebdf745c80a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472534
Reviewed-by: Mahesh Machavolu <mahesh.ma@samsung.com>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291933}
[MediaPrivacy] Enable HideIncognitoMediaMetadata on ToT
Bug: 40269015
Change-Id: I6565ebebd1b2b23901bcb8742857d7c57bc4918d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5478068
Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Filipa Senra <fsenra@google.com>
Cr-Commit-Position: refs/heads/main@{#1291932}
Never return kNoSuchExecutionContext for window commands
This commit makes sure that window commands in ChromeDriver never fail
with the non-standard "no such execution context" error.
Bug: chromedriver:4379
Change-Id: I77a8fe22e1e68ccf522a4b88f7b7dd6b1db09968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5483606
Reviewed-by: Maksim Sadym <sadym@chromium.org>
Commit-Queue: Vladimir Nechaev <nechaev@chromium.org>
Auto-Submit: Vladimir Nechaev <nechaev@chromium.org>
Commit-Queue: Maksim Sadym <sadym@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291931}
settings: Add click handler + actionable styles to startup sound toggle
This CL applies the new attribute 'actionable-row' added in
https://crrev.com/c/5463288 to the audio setting
"Device startup sound enabled". This CL also adds a click handler to
the setting row to match the behavior of settings-toggle-button.
Demo videos:
(note: the cursor position in the videos are slightly offset,
seems like an issue with the screen recording, not sure what happened)
Before:
https://screencast.googleplex.com/cast/NTIwNjE3OTQyMzcxNTMyOHwwMTk3MWQ0ZS02ZQ
After:
https://screencast.googleplex.com/cast/NTA5MzM4MzMxNDg2NjE3Nnw1YzFmYzU1MS1lZQ
Test: Verified on DUT
Test: browser_tests --gtest_filter=*AudioPage*
Bug: b/335686680
Change-Id: I576b337b2d670e973605c566568b3f83796ca395
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472337
Commit-Queue: Camden Bickel <cambickel@google.com>
Reviewed-by: Wes Okuhara <wesokuhara@google.com>
Cr-Commit-Position: refs/heads/main@{#1291930}
Roll Chrome Lacros Arm64 Generic PGO Profile
Roll Chrome Lacros Arm64 PGO profile from chrome-chromeos-arm64-generic-main-1713916645-e2333cd423bfde1526f36a6e496980f9f5085e90-fccc19e1196d83e5127b1a5418d13393b432b969.profdata to chrome-chromeos-arm64-generic-main-1713960372-8f2f21dc64eab126afcec20fa29a5c87f0291d7e-1685c9a02574d4cf9f481c194f0923ff757158fb.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-lacros-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I02e6d93b7df65da45fab0239cc14f510f0f7e182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5483948
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291929}
Support Data Controls paste replacement for same tab pastes
This CL adds the necessary code so that pastes with data originating
from the same tab which don't call `PasteIfAllowedByPolicy` can still
have their pasted content changed by Data Controls if its internal
clipboard has data.
Bug: 313091312
Change-Id: I4ef8c5813712427e62e70c8aae6cbe31024aa6e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5439894
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Nancy Xiao <nancylanxiao@google.com>
Cr-Commit-Position: refs/heads/main@{#1291928}
WebSQL: Restrict WebSQL service creation to Android only
This change restricts WebSQL service creation to Android
only. WebSQL is fully removed from all platforms in M119
except for Android WebView(crbug.com/333756088). Next step
will be to delete WebSQL data for removed platforms.
Intent thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/fWYb6evVA-w/m/wGI863zaAAAJ
Bug: 40910849
Change-Id: I9a52cfe900f041d57b301faa6584077c19be6137
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5459367
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291927}
[CrOS Hotspot] Don't show "Turn on Hotspot" button change to disallowed
When hotspot is disabled due to long time inactivity or internal error,
a notification with "Turn on Hotspot" button will be shown. If the
hotspot is not allowed at the time user click on the Turn on button,
it will attempt to turn on hotspot and contribute to failure data point
to enable hotspot success metrics. This change modifies the notification
to only show the Turn on button when it's allowed and dismiss the
notification if it changes to not allowed.
Bug: b/336611750
Test: manually tested on DUT
Change-Id: I8e324c8da93d698c1ffb47587aef2dbc6fefd9ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5479993
Reviewed-by: Theo Johnson-kanu <tjohnsonkanu@google.com>
Commit-Queue: Jason Zhang <jiajunz@google.com>
Reviewed-by: Nikhil Nayunigari <nikhilcn@google.com>
Reviewed-by: Jiaming Cheng <jiamingc@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291926}
Roll ios_internal from 3292e3855534 to 41b4928328ee
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/3292e3855534..41b4928328ee
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,djean@google.com,ewannpv@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: Ia4039a57c1857cc6162da02293a249970febb7e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5482559
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291925}
[IOS][Omnibox] Prepare experimental flag for actions in suggest
Change-Id: I8c9192a5bc9690676667ef1f2f235641bc2c2348
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5474122
Auto-Submit: Ameur Hosni <ameurhosni@google.com>
Commit-Queue: Ameur Hosni <ameurhosni@google.com>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291924}
Add arm config to cr_cronet
Change-Id: I4bb01ba26cf284fe60a1639cf17ff9fc064ee0a6
Bug: b/331170780
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5483506
Reviewed-by: Stefano Duo <stefanoduo@google.com>
Auto-Submit: Chidera Olibie <colibie@google.com>
Commit-Queue: Stefano Duo <stefanoduo@google.com>
Cr-Commit-Position: refs/heads/main@{#1291923}
[blinkpy] Make `TryJobStatus` a flat enum
* Use a real enum and remove magic string constants, which can mask
misspellings (e.g., `... == TryJobStatus('bogus')` won't raise an
exception).
* Some combinations of the status/result pair are invalid and should not
be representable. Completion should be represented as a mask of
constituent statuses [0] instead of a dedicated field.
* Rename to `BuildStatus` for consistency with Buildbucket and other
areas of `blinkpy`.
No functional change.
[0]: https://source.chromium.org/chromium/_/chromium/infra/luci/luci-go/+/df660c4f5abd367a17ba22e7574c342f33ae72db:buildbucket/proto/common.proto;l=37;drc=a826ec2fad0cfc0864fe9e83a74746facc87eb5a;bpv=0;bpt=0
Bug: None
Test: git cl issue 5120391
Test: ./blink_tool.py rebaseline-cl --dry-run --patchset=1
Change-Id: Idf5a5b172159418ecf9eda013f7671c384014a52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5480289
Reviewed-by: Weizhong Xia <weizhong@google.com>
Commit-Queue: Jonathan Lee <jonathanjlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1291922}
Roll Help App from ApfdaVhIws_Yj0aZ1... to qbxesEAiWAtrSRBEb...
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202404240800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/qbxesEAiWAtrSRBEb1J5kEeD0DTn2HU70tNFJ3K8pPoC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC cros-essential-apps-dev@chromium.org,help-app@grotations.appspotmail.com,jomag@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: help-app@grotations.appspotmail.com
Change-Id: I63727c238b3149721df2b4dab216901b797d45d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5482895
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291921}
enums: support flog ap ro verification subevents
AP RO verification subevents were added in crrev.com/c/5454717 and
crrev.com/c/5459201. Add strings for the new event codes.
BUG=b:183217155
TEST=none
Change-Id: I8e26eecfbed3e20281578aa9d82f3eb637857ec3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5455395
Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Yi Chou <yich@google.com>
Auto-Submit: Mary Ruthven <mruthven@chromium.org>
Commit-Queue: Mary Ruthven <mruthven@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291920}
views: use CalculatePreferredSize(SizeBounds) in //chromeos.
In order to ensure implementation consistency and avoid oversights, we
should unify CalculatePreferredSize() and GetHeightForWidth(). Replace
them with the CalculatePreferredSize(SizeBounds) overload.
Bug: 40232718
Change-Id: I15fc9259b2054a4fd3adc3ee44f79dc12531b90b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5482447
Commit-Queue: Weidong Liu <weidongliu@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291919}
Shared Storage: Log fine-grained non-web-visible worklet error types
Previously in shared storage worklet UMA metrics, we had broad error
buckets for the method and whether or not the error is web-visible.
The web-visible errors are something that developers can get feedback
on directly. But in a recent spike of non-web-visible errors, it would
have been nice to have finer-grained buckets to help see what was
going on. Here we split up the non-web-visible errors into more
specific buckets.
Bug: 335923910
Change-Id: I6609dc2aa888b8eafc76b4cb7924b894fba16f5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5462289
Reviewed-by: Yao Xiao <yaoxia@chromium.org>
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291918}
[Passwords][Settings] Update label in the passkey card if PIN exists
If the user has a PIN, the mobile device is not needed.
Impl: screen/8mBcAJLxyYhPwFZ
Bug: 331611435
Change-Id: I8d6e8dfccaaac103b7fd23451a8f1eaf7f0f2e81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5481801
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Adem Derinel <derinel@google.com>
Reviewed-by: Andrii Natiahlyi <natiahlyi@google.com>
Cr-Commit-Position: refs/heads/main@{#1291917}
Revert "[LHS indicator] Add Kombucha tests for permissions dashboard view"
This reverts commit b9cb5fd6943f20dbb8c9ffbf7583fbeecf5bae72.
Reason for revert: DashboardKombuchaInteractiveUITest tests introduced by this CL are failing. https://ci.chromium.org/ui/p/chrome/builders/ci/mac-rel-ready/15376/overview
Original change's description:
> [LHS indicator] Add Kombucha tests for permissions dashboard view
>
> This CL adds a new file for interactive UI tests to verify LHS
> indicators and PageInfo changes. Additionally it moves a few
> chip-related tests under /chip folder.
>
> Bug: 41487636,41483562
> Change-Id: I1c2d309c3ac1fb79476d38119f7e523b51a8b6ef
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5388660
> Reviewed-by: Ravjit Uppal <ravjit@chromium.org>
> Commit-Queue: Elias Klim <elklm@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1291876}
Bug: 41487636,41483562
Change-Id: I7be00267a31b0b11960b799722a04fe0ace92f18
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5482408
Owners-Override: Kevin McNee <mcnee@google.com>
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291916}
Fenced frame: Network cutoff callback waits for sub-fenced frames.
The `window.fence.disableUntrustedNetwork()` promise currently resolves
as soon as the frame's config's partition nonce is added to the network
cutoff list. However, the features gated behind network cutoff
(currently just `sharedStorage.get()`) still aren't allowed to be
accessed until all sub-fenced frames have also cut off their own
network. Sub-fenced frames still need to turn off their own network by
calling `disableUntrustedNetwork()`. To enforce that, we check every
sub-fenced frame for network cutoff whenever we call
`sharedStorage.get()`.
This CL modifies the behavior to not have the promise resolve until
network cutoff has truly kicked in. In other words, once all sub-fenced
frame trees have had their network cut off, only then will
`window.fence.disableUntrustedNetwork()` resolve.
Because it's possible for a sub-fenced frame's network cutoff call to resolve a
promise, the callback for the promise is stored in the fenced document
data if it's not resolved during the course of its
`disableUntrustedNetwork()` call. During each
`disableUntrustedNetwork()` call, each fenced frame properties' network
cutoff value is recalculated, taking child properties' network cutoff
values into account. If it is determined that this frame is ready for
network cutoff, the bit is flipped in its properties and the frame's
document's original `window.fence.disableUntrustedNetwork()` function
call is resolved.
The function that determines the network cutoff status involves a full
traversal of the entire frame tree (including crossing fenced frame
boundaries) to determine what frames have been affected by a
`disableUntrustedNetwork()` call, starting with the most deeply nested
frames and working up the frame tree.
See explainer: https://github.com/WICG/fenced-frame/blob/master/explainer/fenced_frames_with_local_unpartitioned_data_access.md#revoking-network-access
See overall design document: https://docs.google.com/document/d/1JnwuFl84P5jR_9PkpM68WdCD63UerKxWm-v4XXj2sRc/edit?usp=sharing
Change-Id: I88522ea9d3a7d261124fc740681c27537b056cdb
Bug: 41488151
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5426603
Commit-Queue: Liam Brady <lbrady@google.com>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Garrett Tanzer <gtanzer@chromium.org>
Reviewed-by: Andrew Verge <averge@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291915}
[iOS][TG] Update DetermineNewActiveIndex:
When closing a tab in a group, the next active tab should be the
closest one in the same group.
Fixed: 336263731, 1395319
Change-Id: Icbf35ee275f8e26906e6f4c9d08c9e7c02c61924
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5471727
Reviewed-by: Louis Romero <lpromero@google.com>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291914}
Disable ProductSpecificationsTest.ProductSelector for flakiness
Bug: 336414352
Change-Id: Ibc348585f28ac29149ff38a3392ede314fde5b96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5482689
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Jihad Hanna <jihadghanna@google.com>
Reviewed-by: Jihad Hanna <jihadghanna@google.com>
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291913}
Add support for flagging extensions without privacy practices
Add support for displaying extensions in the Extensions Safety
Hub that have not disclosed their privacy practices in their
CWS listings. Note that this CL uses existing strings for off-store
extensions as a placeholder. Once the real strings are finalized, they
will be added in a follow-on CL.
Bug: b/334110393
Change-Id: I2c4d6b2396db2ee46932f18a6a1e59f198566eaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5462027
Commit-Queue: Adam Psarouthakis <psarouthakis@google.com>
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Reviewed-by: Side YILMAZ <sideyilmaz@chromium.org>
Reviewed-by: Anunoy Ghosh <anunoy@chromium.org>
Reviewed-by: Richard Chen <richche@google.com>
Cr-Commit-Position: refs/heads/main@{#1291912}
[chromebox_for_meetings] Refactor non-incremental sources
This commit adds a new distinguishing property of the local
DataSource objects that states whether or not the source
returns "incremental" data. Incremental data is data that
is ordered and time-based, like the data in a log file.
Non-incremental sources are typically state-based, meaning
they produce data that represents the state of the system
at any given time.
This separation is important for a few reasons:
1. It allows us to deny certain watchdogs. Incremental
sources do not support CHANGE watchdogs, for example.
2. We should only be uploading state-based data if it is
different from the previous state, which is logic that
was previously localized to |CommandSource|. This moves
the logic into the |LocalDataSource| parent and allows
us to reuse said logic for future state-based sources,
eg |ProcessSource|, |TelemetrySource|, etc.
3. State-based sources will require special consideration
when watchdog support is eventually added. We want to
"force" fetch the data, even if it is the same, in order
to check the data for watchdog matches.
Bug: b:326440932
Change-Id: Iab6f957c6560814db41d93baceea48fa8a8ab01b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5466545
Commit-Queue: Niko Tsirakis <ntsirakis@google.com>
Reviewed-by: Kyle Williams <kdgwill@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291911}
Roll ANGLE from d4519fdce606 to 0e7d735b144d (2 revisions)
https://chromium.googlesource.com/angle/angle.git/+log/d4519fdce606..0e7d735b144d
2024-04-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 9aec4b969291 to 76f7f8cfea80 (1 revision)
2024-04-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from b00758dcbb7a to 4433c533fffb (891 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: ynovikov@google.com
Change-Id: I3c924177f1892e8d81b871cc562cc7fafa3145b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5482551
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291910}
Remove CSSLinearTimingFunctionEnabled flag
Flag has been enabled since M113.
Bug: 40256903
Change-Id: I0852393ec81ec18d058c305c85f2a3de3dc7c75d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5479611
Reviewed-by: Daniil Sakhapov <sakhapov@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1291909}
[pre_freeze] Rename "*Gpu*" metrics to "*GPU*"
This CL corrects the "Memory.PreFreeze2.Gpu.PrivateMemoryFootprint.*"
metrics to "Memory.PreFreeze2.GPU.PrivateMemoryFootprint.*", to match
the histogram file.
Bug: 334144248
Change-Id: I932e80802d8bc13ca0ac141ddea1ce32a3fb9c9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5476748
Reviewed-by: Benoit Lize <lizeb@chromium.org>
Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com>
Cr-Commit-Position: refs/heads/main@{#1291908}
Separate else ifs to ifs in RenderProcessHostImpl::Cleanup
All the cases of the else ifs have an early return, so clean up to just
be ifs, rather than else ifs.
Test: No behaviour change
Bug: 323753235
Change-Id: I796aa0ed6eb93c7ec148ac3ad5eb56f7d6b00991
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472198
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Sharon Yang <yangsharon@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291907}
Add dayeung@ as owner for vector icon definitions.
R=dayeung@chromium.org
Bug: none
Change-Id: I67f9d1595f27040d6e246125676f4ac96d75dca6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5481267
Commit-Queue: David Yeung <dayeung@chromium.org>
Auto-Submit: Evan Stade <estade@chromium.org>
Reviewed-by: David Yeung <dayeung@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291906}
Keep pseudo-elements during moveBefore
This happens by default since we don't detach the layout,
but this CL removes the assertions that the psuedo-elements are gone.
Bug: 40150299
Change-Id: I6200dd8ff0902b1e0d2950009ce46f51f53eda59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5481991
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291905}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1713949119-53e697fecc99e5d7c2b643b1f0141e189e939c2d-3f3281cf1bd1815e5ca4172ebcc59390e9741ab2.profdata to chrome-win64-main-1713959768-d3aca89f7ec780600180addb70e125f09f90fb9e-8c57b87c7e93ac061c9e1026960b8c062a22d2dd.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I35034f92a860787e0f474e8daa9843fe64c20214
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5482707
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291904}
Roll androidx from FQ0Gim7l-LJP1XNsx... to zjTkDjEytq8UvMcux...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/androidx-chromium
Please CC clank-build@google.com,clank-library-failures@google.com,wnwen@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel
Tbr: clank-library-failures@google.com
Change-Id: Ib14f167658ca66d8f942ec00bf57e3de78a5271d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5482552
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291903}
[Scroll Jank] Update scroll offsets metrics to utilize correct timestamps.
PERFETTO_TESTS=`autoninja -C out/Default perfetto_diff_tests && out/Default/bin/run_perfetto_diff_tests
Bug: b/304474660
Change-Id: I3ffd048f805d82bd4ff72900ebf7316b775f2ab9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5438434
Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Omar Elmekkawy <mekk@chromium.org>
Commit-Queue: Harkiran Bolaria <hbolaria@google.com>
Cr-Commit-Position: refs/heads/main@{#1291902}
Remove unused function IDs in InterceptorId enum
Some IDs in this enum can be deleted as the corresponding
functions are no longer intercepted.
Bug: n/a
Change-Id: Icde3f62a7f889fdb7298f9c012913874ab8d16f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5479736
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291901}
[webview][trackpad] Update experiment group in fieldtrial_testing_config.json to bump WebView rollout of trackpad features to 50% stable.
Bug: 40900218
Change-Id: I99325febadcb8aecb25ee25f95d49d9dc93a2041
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5481955
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Wayne Jackson Jr. <wbjacksonjr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291900}
[PwaRestore]: Restore button should close dialog.
Test (and batteries) included.
Bug: 40281671
Change-Id: Ib9b1dbc2a09814d39549f0631b5566616f905fa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5483066
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291899}
Import wpt@d0649743f613ff12c570642bd1782433d1b0d390
https://github.com/web-platform-tests/wpt/compare/55cb997b1...d0649743f
Using wpt-import in Chromium 1107b3359b28613652cdbbcc28764081a2942bdb.
With Chromium commits locally applied on WPT:
ba72618e97 "webnn: Move TFLite execution to the thread pool"
Note to gardeners: This CL imports external tests and adds expectations
for those tests; if this CL is large and causes a few new failures,
please fix the failures by adding new lines to TestExpectations rather
than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
NOAUTOREVERT=true
No-Export: true
Validate-Test-Flakiness: skip
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Change-Id: I1fc80acb00c974410807f3607a2b599ac1f69137
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5479269
Reviewed-by: Weizhong Xia <weizhong@google.com>
Commit-Queue: Weizhong Xia <weizhong@google.com>
Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291898}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1713949119-2b66cfaa8819dd3203636931ad5bd560b7bc4787-3f3281cf1bd1815e5ca4172ebcc59390e9741ab2.profdata to chrome-win32-main-1713959768-0a8c007f489f073f7641109c3ed054b5bc0c66bf-8c57b87c7e93ac061c9e1026960b8c062a22d2dd.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I091a2495a5c94d6fc42fbf61734c7c31c5c7b71b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5482708
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291897}
Fix command line corruption in gl_tests.
In these tests, we were storing argc and argv, then calling
InitGoogleMock which altered argv - and did not update argc
correspondingly.
This meant that the test suite believed it had (for instance) 9 elements
in argv, but actually only had 8.
This caused problems when we came to add FuzzTest support, but might
have caused other problems.
Fix this by initializing GMock prior to storing argc/argv.
Bug: 40286211
Change-Id: I8f426a0a5c2b2e3440849d01e5751bda9f182303
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5483126
Commit-Queue: Victor Miura <vmiura@chromium.org>
Auto-Submit: Adrian Taylor <adetaylor@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Adrian Taylor <adetaylor@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291896}
Remove NOTIMPLEMENTED() macros in shell_integration_android.cc.
These seem to spam logs (e.g. browser tests) and given we've not had a need to implement these for a decade, seems we could spare the spam.
Change-Id: I2448ee55546229d7e4aac6de51bdeeace6e01c8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472797
Auto-Submit: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291895}
Reland "[Uno-D] Enable fieldtrial_testing_config for full phase"
This is a reland of commit 3b980d0bd50a84f848f2bf420646bf9fbcbb1b98
Reason for revert: A bot post commit failed, it had the flag
`--disable-field-trial-config` which runs the test ignoring the
field_trial_configs that were modified in the CL. It broke part of
the `PrimaryAccountResetAfterSyncOptInFlowAborted` test.
Fix: Make `PrimaryAccountResetAfterSyncOptInFlowAborted` parametrized
and adapted based on the feature flag that is being enabled by default
through the config.
Original change's description:
> [Uno-D] Enable fieldtrial_testing_config for full phase
>
> Followup to https://crrev.com/c/5397876.
> Adapted some remaining tests.
>
> Bug: b/326204909
> Change-Id: I4e86958bb2d815d4c3db59be78689bbe276e81bf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5407891
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Commit-Queue: Ryan Sultanem <rsult@google.com>
> Reviewed-by: Yann Dago <ydago@chromium.org>
> Reviewed-by: Monica Basta <msalama@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1288640}
Bug: b/326204909
Change-Id: I7587c9dafc9371b2885e78ae4a84a8599552d86a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5464524
Reviewed-by: Yann Dago <ydago@chromium.org>
Reviewed-by: Monica Basta <msalama@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Ryan Sultanem <rsult@google.com>
Cr-Commit-Position: refs/heads/main@{#1291894}
Define structs for Rekor header file.
Part of porting Oak attestation from Rust to C++.
https://github.com/project-oak/oak/blob/main/oak_attestation_verification/src/rekor.rs#L122
Bug: b/324141620
Change-Id: I3e48716b1591e099ab638679e1840d6e4b3dbac2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5478019
Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Livia Seibert <livseibert@google.com>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291893}
Prune ComputeVisibleSelectionInDOMTreeDeprecated from InputMethodController
This patch prunes several sites of the deprecated function by:
- hoisting layout update out from it:
- InputMethodController::CancelComposition.
- InputMethodController::TextInputInfo.
- layout already clean:
- InputMethodController::ClearImeTextSpansByType.
- InputMethodController::FinishComposingText.
- InputMethodController::ReplaceComposition.
- InputMethodController::ReplaceCompositionAndMoveCaret.
- InputMethodController::InsertTextAndMoveCaret.
- InputMethodController::SetComposition.
- InputMethodController::SetCompositionFromExistingText.
- InputMethodController::AddImeTextSpansToExistingText.
- InputMethodController::GetSelectionOffsets.
- InputMethodController::EphemeralRangeForOffsets.
- InputMethodController::CreateRangeForSelection.
- InputMethodController::ExtendSelectionAndDelete.
- InputMethodController::DeleteSurroundingText.
- InputMethodController::GetImeTextSpans.
Bug: 40509385
Change-Id: I2ae411821ae41189061d5db0223e2e6e3c88a49c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472192
Commit-Queue: Siye Liu <siliu@microsoft.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Anupam Snigdha <snianu@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1291892}
[TTF] Don't show TTF for new-password forms
With the PasswordSuggestionBottomSheetV2 feature flag on and sync off
TTF currently gets triggered for new-password forms. This CL fixes the
issue by checking if the form is a normal login form in the
TouchToFillControllerAutofillDelegate. Core points:
- PasswordForm which will be filled is now cached in the password form
manager.
- GetFormToFillForFieldId is introduced into password manager to expose
the form which needs to be filled to the client.
- The form to fill is passed into TTF delegate so that the delegate
could check the type of the form before TTF is triggered.
- TTF controller queries from the TTF delegate whether it should show
the bottom sheet.
- SubmissionReadinessParams is renamed to PasswordFillingParams as it
stores a bunch of password form characteristics not necessarily related
to submission readiness.
Bug: 330515448
Change-Id: I8fabff9ad267b4ac99d07fcc139a6195514aefcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5444517
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Anna Tsvirchkova <atsvirchkova@google.com>
Cr-Commit-Position: refs/heads/main@{#1291891}
Update CertVerifierServiceFactory.GetChromeRootStoreInfo to pass entire
certificate bytes as they'll be needed by Cert Management UI for multiple
reasons.
Bug: 1477317
Change-Id: I054698bfbe90714f9011f502dc30704f948747fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5453802
Reviewed-by: Matt Mueller <mattm@chromium.org>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Commit-Queue: Hubert Chao <hchao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291890}
Fenced frames: Cancel in-progress requests upon network revocation [4/N]
For fenced frames network revocation, previously we only cancelled in-
progress requests with URLLoader. Now we also cancel for CorsURLLoader.
Bug: 1515599
Change-Id: Idc8e7554d919c9544e6837d2ae1c0e6fcd7ae73f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5448555
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Garrett Tanzer <gtanzer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291889}