Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart2js: --disallow-unsafe-eval broken #7224

Closed
rakudrama opened this issue Dec 8, 2012 · 5 comments
Closed

dart2js: --disallow-unsafe-eval broken #7224

rakudrama opened this issue Dec 8, 2012 · 5 comments
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Milestone
M2

Comments

@rakudrama
Copy link
Member

It appears to have broken when the superclass was moved into the fields string.
Under --disallow-unsafe-eval, the '': member is the constructor function, i.e. not a string.
@rakudrama
Copy link
Member Author

Fix available https://codereview.chromium.org/11491005/

@rakudrama
Copy link
Member Author

Issue #7228 has been merged into this issue.

@DartBot
Copy link

DartBot commented Dec 10, 2012

This comment was originally written by @financecoding

BTW, patch worked great for me. I applied it to the sdk version downloaded on Issue #7228 , going to run a few more tests with it. I was trying to create a chrome app and ran into this issue.

@rakudrama
Copy link
Member Author

Fixed r15886

Added Fixed label.

@kasperl
Copy link

kasperl commented Dec 12, 2012

Issue #7326 has been merged into this issue.

@rakudrama rakudrama added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js labels Dec 12, 2012
@rakudrama rakudrama added this to the M2 milestone Dec 12, 2012
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Projects
None yet
Milestone
M2
Development

No branches or pull requests
3 participants
@rakudrama @kasperl @DartBot